Bug 99723 - [ViewMgmt] [RCP] Can dock a non-moveable fast view
Summary: [ViewMgmt] [RCP] Can dock a non-moveable fast view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Paul Webster CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-13 12:31 EDT by Nick Edgar CLA Friend
Modified: 2005-09-20 13:26 EDT (History)
1 user (show)

See Also:

Attachments
ui.workbench non-moveable fast view (6.08 KB, patch)
2005-08-31 13:39 EDT, Paul Webster CLA Friend 		no flags Details | Diff
ui.tests added a test for non-moveable fast view (4.98 KB, patch)
2005-08-31 13:42 EDT, Paul Webster CLA Friend 		no flags Details | Diff
3.2 ui.tests added a test for non-moveable fast view (4.96 KB, patch)
2005-09-14 10:18 EDT, Paul Webster CLA Friend 		no flags Details | Diff
3.2 ui.workbench non-moveable fast view (5.24 KB, patch)
2005-09-14 10:19 EDT, Paul Webster CLA Friend 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA Friend 2005-06-13 12:31:04 EDT 
3.1 RC2

The "Fast View" toggle in the fast view bar is always enabled, even if the view
is non-moveable.  It should be hidden or disabled if the view is non-moveable.

See also bug 88345.
Comment 1 Paul Webster CLA Friend 2005-08-31 13:39:50 EDT 
Created attachment 26723 [details]
ui.workbench non-moveable fast view

A non-moveable fast view should be prevented from docking.

PW
Comment 2 Paul Webster CLA Friend 2005-08-31 13:42:11 EDT 
Created attachment 26724 [details]
ui.tests added a test for non-moveable fast view

Added a test that reports if a non-moveable view has Fast View menu item
accessible.

Found during testing that PageLayout had a bug ... addFastView(id) said it took
a compound ID, but the code never checked for a compound ID.

PW
Comment 3 Paul Webster CLA Friend 2005-08-31 13:47:44 EDT 
Nick, could you please review these patches and submit them to 3.1.1 (and 3.2)?

I've run all of the tests (UI/RCP/JFACE) and they all pass.

PW
Comment 4 Kim Horne CLA Friend 2005-09-13 14:53:12 EDT 
Has this been submitted?
Comment 5 Paul Webster CLA Friend 2005-09-13 14:56:44 EDT 
Submitted into 3.1.1 >20050913
Comment 6 Kim Horne CLA Friend 2005-09-13 15:01:58 EDT 
Marking as fixed
Comment 7 Michael Van Meekeren CLA Friend 2005-09-13 15:26:02 EDT 
submitted for 3.1.1 - what about 3.2?
Comment 8 Paul Webster CLA Friend 2005-09-14 10:18:46 EDT 
Created attachment 27108 [details]
3.2 ui.tests added a test for non-moveable fast view
Comment 9 Paul Webster CLA Friend 2005-09-14 10:19:09 EDT 
Created attachment 27109 [details]
3.2 ui.workbench non-moveable fast view
Comment 10 Tod Creasey CLA Friend 2005-09-14 11:26:36 EDT 
Patches released to HEAD
Comment 11 Paul Webster CLA Friend 2005-09-20 13:26:37 EDT 
verified for 3.2 on I20050920-0010