Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 98894 - Shell.setImages() should be smarter on Mac
Summary: Shell.setImages() should be smarter on Mac
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.1   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 98933 98985 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-08 04:32 EDT by Tom Hofmann CLA
Modified: 2008-06-03 17:40 EDT (History)
7 users (show)

See Also:


Attachments
transparent.png (46.74 KB, image/png)
2005-06-08 04:35 EDT, Tom Hofmann CLA
no flags Details
screenshot of bad icon (22.59 KB, image/png)
2005-06-27 19:03 EDT, Stefan Xenos CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2005-06-08 04:32:04 EDT
N20050608-gtk

The new transparent icons are not correctly handled on the Linux-GTK platform.
The icons in the task bar and the task switcher (Alt+TAB) are not rendered with
transparency. Will attach a screenshot.
Comment 1 Tom Hofmann CLA 2005-06-08 04:35:23 EDT
Created attachment 22593 [details]
transparent.png

Screenshot of my task switcher.

The currently selected window is the Gimp window for the eclipse48.png file
showing correct transparency - so it is possible to get it right.

To its right is the icon for the eclipse window. Note the white and black
borders to to converted transparency areas.

Feels at least major for me as shipping this looks really bad.
Comment 2 Billy Biggs CLA 2005-06-08 09:01:14 EDT
This should probably go to SWT.
Comment 3 Billy Biggs CLA 2005-06-08 13:05:04 EDT
mvm: which file is being used on GTK+?  Is it the .ico or the .png files?
Comment 4 Michael Van Meekeren CLA 2005-06-08 14:27:31 EDT
As of last night 2005 06 08 should be ICO files everywhere but the Mac.  I
understood from SN that this was supported.
Comment 5 Steve Northover CLA 2005-06-08 18:22:45 EDT
The problem is that ICO files with alpha are only supported on XP and GTK (and 
we have a bug that is preventing GTK from working).  The GTK bug may be fixed 
after RC2.  We are working to solve the general problem for Eclipse by making 
Shell.setImages() smarter for RC2.  Stand by.
Comment 6 Michael Van Meekeren CLA 2005-06-08 19:39:20 EDT
*** Bug 98985 has been marked as a duplicate of this bug. ***
Comment 7 Michael Van Meekeren CLA 2005-06-08 19:48:24 EDT
*** Bug 98933 has been marked as a duplicate of this bug. ***
Comment 8 Billy Biggs CLA 2005-06-09 16:04:37 EDT
This bug has been used to track the badness of the icons in the Eclipse window
which was solved by making Shell.setImages() smarter.  I have opened bug 99253
about the specific issue of ico files with alpha on GTK+.
Comment 9 Billy Biggs CLA 2005-06-09 16:05:23 EDT
This was fixed by SN and SSQ for the 4pm build today.
Comment 10 Stefan Xenos CLA 2005-06-14 14:17:19 EDT
If this bug is tracking the recent icon cheeze, then this is still a problem on
windows XP in RC3.

The icon in the window title is fixed, but the icon on the task bar is still
badly stretched.
Comment 11 Steve Northover CLA 2005-06-14 15:04:54 EDT
Isn't "cheeze" is spelled "cheese".  Anyhow, can you attach a screen shot of 
the badness?
Comment 12 Steve Northover CLA 2005-06-15 16:46:29 EDT
Stefan, gotta see the badness in XP in RC3 before proceeding because this 
WORKSFORME.  Got a gif?
Comment 13 Steve Northover CLA 2005-06-20 16:55:31 EDT
Somehow, Shell.setImages() was not fixed for the Mac.  The other problems have 
been fixed.
Comment 14 Stefan Xenos CLA 2005-06-27 18:49:11 EDT
The cheeze I'm seeing seems to only occur with 16-bit colour and the 120-DPI
(large size) setting.
Comment 15 Stefan Xenos CLA 2005-06-27 19:03:51 EDT
Created attachment 24055 [details]
screenshot of bad icon

I20050627-1435
Windows XP
120 DPI (large size)

Primary monitor
1600x1200x16, 85 hz
ATI 3D rage pro (PCI)

Secondary monitor
1600x1200x16, 75 hz
NVIDIA Vanta (AGP)

I've reproduced on a MvM's machine, although the cheeze was different. Seems to
be the combination of 120DPI and 16-bit colour that does it.
Comment 16 Stefan Xenos CLA 2005-06-27 19:09:50 EDT
The cheeze seems to depend on the colour depth of the windows primary monitor,
not the monitor containing the start bar.

If I make my AGP card into the primary display (through windows - not the bios)
and change its colour depth to 32, the problem goes away on both monitors.
Comment 17 Michael Van Meekeren CLA 2005-06-29 16:50:37 EDT
when I increase the DPI setting for my graphics card on my laptop to 120 I see
this behaviour as well.
Comment 18 Silenio Quarti CLA 2006-04-10 14:18:43 EDT
Shell.setImages() has been fixed on the Mac.
Comment 19 Steve Northover CLA 2008-06-03 17:37:38 EDT
Is this now fixed?
Comment 20 Silenio Quarti CLA 2008-06-03 17:40:44 EDT
Yes, it was fixed on the Mac.