Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 98099 - Support requested to generate nested source feature
Summary: Support requested to generate nested source feature
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 107603
  Show dependency tree
 
Reported: 2005-06-02 09:30 EDT by Sonia Dimitrov CLA
Modified: 2006-01-19 13:45 EST (History)
1 user (show)

See Also:

Attachments
patch (3.74 KB, patch)
2006-01-17 16:21 EST, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sonia Dimitrov CLA 2005-06-02 09:30:02 EDT 
Currently to generate the nested rcp source feature in 
org.eclipse.platform.source, a hard-coded feature.xml which includes the 
org.eclipse.rcp.source feature is required in the sourceTemplateFeature files 
for org.eclipse.platform.  Would it be possible to remove the need for this 
file if the build.properties for the generated source feature 
(org.eclipse.platform.source) contains the directive to generate another 
source feature, 
ie.
generate.feature@org.eclipse.rcp.source=org.eclipse.rcp?
Comment 1 Andrew Niefer CLA 2006-01-17 16:21:47 EST 
Created attachment 33168 [details]
patch

Here is a proposed patch, which adds the ability to include a feature in a generated source feature as follows:
For the following layout:
SDK -> platform.source -> rcp.source

in SDK build.properties put
generate.feature@org.eclipse.platform.source=org.eclipse.platform, plugin@org.eclipse.platform.doc.isv, feature@org.eclipse.rcp.source

The feature@org.eclipse.rcp.source will result in 
<includes id="org.eclipse.rcp.source" version="0.0.0"/>
being added to the generated platform.source feature.xml

in platform/sourceTemplateFeature/build.properties put
generate.feature@org.eclipse.rcp.source=org.eclipse.rcp
Comment 2 Pascal Rapicault CLA 2006-01-19 13:45:07 EST 
Patch released in HEAD.