Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 97198 - [nls tooling] NLS wizard does not respect line delimiter setting
Summary: [nls tooling] NLS wizard does not respect line delimiter setting
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux-GTK
: P2 normal (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-30 05:35 EDT by Tom Hofmann CLA
Modified: 2005-06-09 09:31 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2005-05-30 05:35:33 EDT 
3.1-RC1 test pass

- linux platform (default=Linux Delimiters: 0x0A)
- workspace default set to windows (0x0D 0x0A)
- project set to use workspace delims
- have a java file with an externalizable string
- execute Source>Externalize Strings
(note: there are not message files yet, so they are created)

> expected: Messages.java and messages.properties have Windows style delimiters
< actual: the newly generated files have Unix style delimiters
Comment 1 Dani Megert CLA 2005-05-30 06:55:24 EDT 
Needs to be investigated for RC2.
Comment 2 Dani Megert CLA 2005-05-31 04:40:38 EDT 
>actual: the newly generated files have Unix style delimiters
Unix style all over or mixed?
Comment 3 Dani Megert CLA 2005-05-31 06:10:32 EDT 
There are two problems here:
1) code formatter is called with 'null' resulting in Platform LD being used
2) a DocumentChange(...) is created with an empty document which results in
Platfrom LD being used and written to the file

We need to look at all clients of 1) and 2)
Comment 4 Dani Megert CLA 2005-06-03 10:17:48 EDT 
Fixed both problems in HEAD and reviewed usages of the CodeFormatterUtil and
DocumentChange.

Filed bug 98276 against JDT UI to review the usage of CreateFileChange (and
subclasses).
Comment 5 David Saff CLA 2005-06-09 08:39:46 EDT 
Verified in N20050609-0010.  Dani, please update state to VERIFIED