96893 – New Product dialog doesn't prompt for required "name" attribute

Bug 96893 - New Product dialog doesn't prompt for required "name" attribute

Summary: New Product dialog doesn't prompt for required "name" attribute

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.1
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	3.1.1
Assignee:	Janek Lasocki-Biczysko
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (2):	99782 102325 (view as bug list)
Depends on:
Blocks:

Reported:	2005-05-26 18:16 EDT by Jared Burns
Modified:	2005-08-17 19:35 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
proposed 3.1.1 patch - name gets set to product ID if it is not filled in by user (1.87 KB, patch) 2005-08-17 15:20 EDT, Janek Lasocki-Biczysko	no flags	Details \| Diff
proposed 3.2 patch - modified editor layout (10.67 KB, patch) 2005-08-17 18:08 EDT, Janek Lasocki-Biczysko	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jared Burns

2005-05-26 18:16:06 EDT

Build 20050523

1. From the Product editor, click the "New..." button next to the "Product ID"
field.
2. Specify a defining Plugin, Product ID, and, application as requested and
click Finish.
3. The product extension that is generated has an error: "Attribute 'name' of
element 'product' must be defined."

The dialog should also prompt the user for the product name.

Comment 1 W W

2005-07-07 19:19:22 EDT

This is also a duplicate of this bug#99782 reported by Pascal.

I'm using 3.1 final and still have the same problem.

Thanks

Comment 2 Wassim Melhem

2005-07-10 00:54:42 EDT

*** Bug 102325 has been marked as a duplicate of this bug. ***

Comment 3 Wassim Melhem

2005-07-10 00:56:12 EDT

*** Bug 99782 has been marked as a duplicate of this bug. ***

Comment 4 Wassim Melhem

2005-08-17 14:09:10 EDT

Janek,

This one is causing unpleasantness for 3.1 users, so we have to address it 
with minimal disturbance for 3.1.1 (ie. no UI changes).  For 3.2, we will do 
it right.

For 3.1.1:
When the user presses Finish, prior to synchronizing, if the product does not 
have a name, generate a name for it.  This way we don't get the error on the 
plugin.xml

For 3.2:
If the product name is not specified in the editor, when the wizard comes up, 
the wizard should contain a field that invites the user to enter a name.  The 
name is mandatory.
It would also be good to move the product name field up to make it first on 
top of the overview page.

Comment 5 Janek Lasocki-Biczysko

2005-08-17 15:20:21 EDT

Created attachment 26211 [details]
proposed 3.1.1 patch - name gets set to product ID if it is not filled in by user

Comment 6 Janek Lasocki-Biczysko

2005-08-17 15:21:59 EDT

Comment on attachment 26211 [details]
proposed 3.1.1 patch - name gets set to product ID if it is not filled in by user

this patch is meant for the R3_1_maintenance branch

Comment 7 Wassim Melhem

2005-08-17 17:12:21 EDT

applied the 3.1.1 patch.
Anxiously awaiting the 3.2 counterpart.

Comment 8 Janek Lasocki-Biczysko

2005-08-17 18:08:24 EDT

Created attachment 26217 [details]
proposed 3.2 patch - modified editor layout

Comment 9 Wassim Melhem

2005-08-17 19:35:10 EDT

patch released with a slight modification.
Thanks Janek.