Bug 96843 - build.xml fixes for x86-64 and newer gcc
Summary: build.xml fixes for x86-64 and newer gcc
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Update-Inbox CLA
QA Contact:
URL:
Whiteboard: obsolete
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-26 14:45 EDT by Billy Biggs CLA
Modified: 2012-07-24 10:14 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Billy Biggs CLA 2005-05-26 14:45:47 EDT
From http://bugs.gentoo.org/attachment.cgi?id=59659, there are some problems
with the build.xml for Linux.

  1. It hardcodes x86 instead of using ${arch} which will break on ppc
     and x86-64.
  2. It passes both -shared and -static to gcc, which confuses newer versions.
     Only pass -shared (and -fPIC).

diff -ur eclipse.orig/plugins/org.eclipse.update.core.linux/src/build.xml
eclipse.amd64/plugins/org.eclipse.update.core.linux/src/build.xml
--- eclipse.orig/plugins/org.eclipse.update.core.linux/src/build.xml	2005-05-13
21:37:28.000000000 +0300
+++ eclipse.amd64/plugins/org.eclipse.update.core.linux/src/build.xml	2005-05-23
21:43:30.000000000 +0300
@@ -5,7 +5,7 @@
   <!-- Set a meaningful default value for when it is not. -->
   <property name="eclipse-home" value="${basedir}/../.."/>
   <property name="jdk-path" value="${java.home}"/>  
-  <property name="destination"
value="${eclipse-home}/org.eclipse.update.core.linux/os/linux/x86/"/>
+  <property name="destination"
value="${eclipse-home}/org.eclipse.update.core.linux/os/linux/${arch}/"/>
   <property name="obj-path"
value="${eclipse-home}/org.eclipse.update.core.linux/src/"/>
   <property name="src-path"
value="${eclipse-home}/org.eclipse.update.core.linux/src/"/>  
   
@@ -47,17 +47,17 @@
     <property name="header-path" value="${jdk-path}/../include"/>
     <property name="header-linux-path" value="${header-path}/linux" />
 
-	<echo message="gcc -o  ${library-file} -shared -I${src-path}
-I${header-linux-path} ${library-file} -static -lc"/>
+	<echo message="gcc -o  ${library-file} -shared -fPIC -I${src-path}
-I${header-linux-path} ${library-file} -lc"/>
 
     <apply executable="gcc" dest="${eclipse-home}/" parallel="false">
       <arg value="-o"/>
       <arg value="${library-file}"/>
       <arg value="-shared"/>
+      <arg value="-fPIC"/>
       <arg value="-I${src-path}"/>
       <arg value="-I${header-path}"/>      
       <arg value="-I${header-linux-path}"/>  
 	  <srcfile/>
-	  <arg value="-static"/>           
       <arg value="-lc"/>	  
       <fileset dir="${src-path}" includes="*.c"/>
       <mapper type="glob" from="*.c" to="*.o"/>
@@ -67,4 +67,4 @@
   </target>
   
   
-</project>
\ No newline at end of file
+</project>
Comment 1 Dorian Birsan CLA 2005-06-02 15:46:15 EDT
possible candidate for rc2
Comment 2 Dejan Glozic CLA 2007-04-13 11:23:02 EDT
This is probably obsolete, but definitely not a P2.
Comment 3 John Arthorne CLA 2012-07-24 10:14:39 EDT
The Eclipse Update component is no longer under development, and no longer exists in the Eclipse Platform 4.x stream. If this problem still occurs in Eclipse Platform 4.2 or later, please enter a new bug report against Equinox p2.