Comment 1 Douglas Pollock 2005-08-25 15:02:40 EDT

*** Bug 96603 has been marked as a duplicate of this bug. ***

Comment 2 Douglas Pollock 2005-08-25 15:06:11 EDT

When fixing this bug, I intend only to make it so that the commands 
architecture reparses the entire registry when a change occurs.  I'm doing 
this as there is a lot of consistency checking done when 
bindings/commands/contexts/handlers are read.  This consistency checking is a 
little bit complicated, and would ultimately require re-examining the entire 
bindings/commands/contexts/handlers model anyway. 
 

Comment 3 Douglas Pollock 2005-08-25 15:40:28 EDT

Created attachment 26476 [details]
Patch to "org.eclipse.ui.workbench"

Comment 4 Douglas Pollock 2005-08-25 15:41:15 EDT

Created attachment 26477 [details]
Patch to "org.eclipse.jface"

Comment 5 Douglas Pollock 2005-08-25 15:41:57 EDT

Created attachment 26479 [details]
Patch to "org.eclipse.ui.tests"

Partially complete patch.  Only one of the seven extension points involved is
tested.

Comment 6 Douglas Pollock 2005-08-26 15:32:47 EDT

Created attachment 26556 [details]
Patch to "org.eclipse.ui.workbench"

Comment 7 Douglas Pollock 2005-08-26 15:33:48 EDT

Created attachment 26557 [details]
Patch to "org.eclipse.ui.tests"

Comment 8 Douglas Pollock 2005-08-26 15:35:20 EDT

Created attachment 26558 [details]
dynamic_classes.zip

This ZIP file wasn't included in the patch to "org.eclipse.ui.tests" for some
reason.  Perhaps it was too large (~25KB)?

Comment 9 Douglas Pollock 2005-08-26 16:07:54 EDT

Created attachment 26561 [details]
Patch to "org.eclipse.ui.workbench"

Fixes a concurrent modification exception.

Comment 10 Douglas Pollock 2005-08-26 16:09:00 EDT

Kim: Can you review the patches?  There's a lot of stuff, so I'm just hoping 
someone can look for stupid mistakes.... 

Comment 11 Douglas Pollock 2005-08-29 11:18:27 EDT

Created attachment 26590 [details]
Patch to "org.eclipse.jface"

This removes the change to the javadoc for 3.1.1 (it will appear in 3.2).

Comment 12 Douglas Pollock 2005-08-29 11:20:08 EDT

Created attachment 26591 [details]
Patch to "org.eclipse.ui.workbench"

Removes a println
Makes sure that model objects with dependencies (e.g., bindings) are re-read
when the dependencies changes as well (e.g., commands, contexts).

Comment 13 Douglas Pollock 2005-08-29 12:26:41 EDT

The patch has been applied to both the R3_1_maintenance stream and HEAD.  It 
should appear in I20050830-0800 and M20050831-1200. 

Comment 14 Douglas Pollock 2005-09-26 13:57:10 EDT

Verified by tests in 3.1.1 RC2 and 3.2 M2.