Community
Participate
Working Groups
Build 20050520 Linux-GTK On Linux-GTK, displaying a MultiStatus with a message containing newlines makes the ErrorDialog way too tall. This seems to be happening because ErrorDialog multiplies the vertical height of the first item in the List of the details area times 7 to create the total List height. Because List items on GTK grow in height to correctly display multi-line Strings, the first item in the list can actually be as tall as many lines of text. This can easily create a dialog that is thousands of pixels tall.
Created attachment 21606 [details] Test_1.0.0.jar Here's a simple test plugin that demonstrates the problem. This doesn't show up on Win32 because the Win32 List can't handle newlines. It just replaces newlines with junk characters and squeezes the text onto a single line.
I was just reviewing potential 3.4 bugs and noticed this one. Moving to Szymon as he is working on ErrorHandling issues. Sorry this lingered in my box for so long. Mea culpa.
Created attachment 97181 [details] Screenshot of new status dialog
(In reply to comment #3) > Created an attachment (id=97181) [details] > Screenshot of new status dialog > The issue is fixed in the new status dialog. However it can still exist in ErrorDialog.
Created attachment 111054 [details] Fix I have used the same mechanism that is used in WorkbenchStatusDialog manager. We cannot rely on item height because it may vary on linux. When opening the details the height of the dialog can only be increased, and while closing - decreased.
Created attachment 111055 [details] mylyn/context/zip
This bug should be retargeted to 3.4.2 or 3.5.
(In reply to comment #7) > This bug should be retargeted to 3.4.2 or 3.5. It was moved to 3.4.1 by accident and it's not critical to have it in 3.4.2. I think that 3.5 is more reasonable target. We've been waiting for a comment from Jared though.
(In reply to comment #8) > We've been waiting for a comment from Jared though. > Did someone ask me a question?
Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6.
I have updated the patch (copyright and default dialog height) and released the patch.
(In reply to comment #11) > I have updated the patch (copyright and default dialog height) and released the > patch. You only committed the change to 'master' which is the 4.x dev stream. You also need to cherry-pick the change into the 'R3_development' branch.
It should be fine now. commit e36d4279dedd9c173d2a1e976c877eaebaac94b2 Author: cdaniel <krzysztof.daniel@gmail.com> 2011-12-30 20:07:11 Committer: Krzysztof Daniel <kdaniel@redhat.com> 2012-01-06 15:37:29 Parent: b5e377f52a1c0bfb4471a2985ed943df45c8904f (Report incompatible environment as 'Error') Branches: R3_development
(In reply to comment #13) > It should be fine now. > > commit e36d4279dedd9c173d2a1e976c877eaebaac94b2 > Author: cdaniel <krzysztof.daniel@gmail.com> 2011-12-30 20:07:11 > Committer: Krzysztof Daniel <kdaniel@redhat.com> 2012-01-06 15:37:29 > Parent: b5e377f52a1c0bfb4471a2985ed943df45c8904f (Report incompatible > environment as 'Error') > Branches: R3_development Did you push? I can't see that commit in R3_development. PW
(In reply to comment #14) > (In reply to comment #13) > > It should be fine now. > > > > commit e36d4279dedd9c173d2a1e976c877eaebaac94b2 > > Author: cdaniel <krzysztof.daniel@gmail.com> 2011-12-30 20:07:11 > > Committer: Krzysztof Daniel <kdaniel@redhat.com> 2012-01-06 15:37:29 > > Parent: b5e377f52a1c0bfb4471a2985ed943df45c8904f (Report incompatible > > environment as 'Error') > > Branches: R3_development > > Did you push? I can't see that commit in R3_development. Me neither.
Now the commit is visible here: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/?h=R3_development I had a local branch that did not track proper remote branch, and the cherry-pick was noop, so was a push.
