Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 95663 - Formatter use of System property of line.separator
Summary: Formatter use of System property of line.separator
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: Kevin Barnes CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 94987
Blocks:
  Show dependency tree
 
Reported: 2005-05-17 17:24 EDT by Darin Swanson CLA
Modified: 2005-05-25 11:29 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2005-05-17 17:24:38 EDT 
Current the Ant xml formatter inserts new lines using
System.getProperty("line.separator").

This will cause problems if the document is edited/formatted on muliple platforms.

We should be using TextUtilities.getDefaultLineDelimiter(IDocument)
Comment 1 Darin Swanson CLA 2005-05-20 20:51:57 EDT 
Fixed up to use the TextUtilities.
Changes to XmlDocumentFormatter, XmlDocumentFormattingStrategy and 
XmlElementFormattingStrategy.
Tests updated in XmlDocumentFormatterTest.
Comment 2 Darin Swanson CLA 2005-05-20 20:52:12 EDT 
Please verify Kevin.
Comment 3 Kevin Barnes CLA 2005-05-25 11:29:31 EDT 
verified