Community
Participate
Eclipse IDE
Build: N20050517-0010 (also in M7) 1) Open a Java editor 2) Tear off the Package Explorer 3) Click inside the Java editor 4) Click on an element in the Package Explorer 5) Hit the Delete key -> Deletion occurs in the editor, even though Package Explorer is the active part. Note this is *only* a problem with the delete key, all other keys seem to go to the package explorer (character keys, arrow keys, etc).
*** Bug 95468 has been marked as a duplicate of this bug. ***
*** Bug 98264 has been marked as a duplicate of this bug. ***
*** Bug 102143 has been marked as a duplicate of this bug. ***
*** Bug 102750 has been marked as a duplicate of this bug. ***
Upgrading to major, as this bug seems to be noticed by a fair number of people.
This appears to be another manifestation of bug 66666 which involved the Copy operation not working in a detached Console view (only when using the accelerator, Ctrl-C). These all represent 'retargetable' actions so my best guess is that that they aren't being targeted to the detached view on activation...
This is definitely related to the following code (from Workbench:init)... final ActivePartSourceProvider activePartSourceProvider = new ActivePartSourceProvider( this); handlerService.addSourceProvider(activePartSourceProvider); contextService.addSourceProvider(activePartSourceProvider); The source provider (I'll call it the 'APSP') controls the life-cycle of a part changed listener based on the activation or deactivation of an IWorkbenchWindow (as well as Open and Close). When activation is passed into a part in a DetachedWindow the WorkbenchWindow deactivates, causing the ActivePartSourceProvider's (APSP) part listener to be removed which, in turn, leads to the various defects being reported. I've hacked the current code to prevent the APSP from either adding or removing its part listener and everything seems to work fine (including multiple windows on the same workbench which is what this looks to be for), including the defect scenarios... The current DetachedWindow implementation registers its shell with the 'context' service but there'a no corresponding code for registering with the 'handler' service. How this relates to the control of the accelerator keys is still a mystery. Hints on a non-hack fix based on this info are welcome...;-).
We could sit down and look at this tomorrow. It's probably just a matter of creating a source provider for the detached window.
*** Bug 99470 has been marked as a duplicate of this bug. ***
*** Bug 66666 has been marked as a duplicate of this bug. ***
Created attachment 25699 [details] Keep Key bindings synch'd when a Detached View activates I've marked bug 66666 & bug 99470 as Dup's as well...
It would have been cooler to keep bug "66666" open and mark this as a duplicate of that one ;)
Maybe we should reserve '666' defect numbers for the truly evil defects...;-).
I've committed Eric's patch under the moniker of Bug 66666, so it will appear in the build notes. We can't let an opportunity like this pass us by....
Is it possible to make this fix a part of the 3.1.1 release (Maintenance Builds)?
The concensus is that this looks to be a good candidate for 3.1.1 inclusion. We'll wait for DougP to give his input before actually proceeding however (next week).
I believe this bug is a safe candidate for 3.1.1. Re-opening so it can be verified on the 3.1.1 branch.
Fixed in R3_1_maintenance
Verified in 3.1.1 RC2
Verified (Windows XP, build M20050923-1430)
