Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 94825 - [WorkingSets] possible problem in shutdown sequence
Summary: [WorkingSets] possible problem in shutdown sequence
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-11 15:25 EDT by Susan McCourt CLA
Modified: 2008-05-06 11:36 EDT (History)
2 users (show)

See Also:
bokowski: review+


Attachments
Patch against workbench (934 bytes, patch)
2008-05-05 11:53 EDT, Kim Horne CLA
eclipse: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2005-05-11 15:25:51 EDT
Please see bug #94540 for a problem whereby the operations support was being 
disposed during WorkbenchPlugin.stop() and therefore trying to dispose 
operations from plug-ins that were already gone.  The fix would be to move the 
dispose code from WorkbenchPlugin.stop() to WorkbenchPlugin.reset().  

I noticed that all of the other support/registry objects managed by 
WorkbenchPlugin are disposed only in the reset() method, except for the 
workingSetManager, which does it in both methods.

I don't know that this is a problem, just thought I should point out the 
difference.
Comment 1 Kim Horne CLA 2007-06-05 13:46:33 EDT
Will look in 3.4.  
Comment 2 Kim Horne CLA 2008-05-02 15:23:07 EDT
Will investigate for RC1 but it might be scary enough to punt to 3.5
Comment 3 Kim Horne CLA 2008-05-05 11:53:34 EDT
Created attachment 98652 [details]
Patch against workbench
Comment 4 Kim Horne CLA 2008-05-05 11:54:23 EDT
Could I get a +1 here Boris?  It seems that we were already doing this work in workbench.reset()...
Comment 5 Kim Horne CLA 2008-05-05 13:14:30 EDT
Ooops.  Forgot to add you, Boris.  +1?
Comment 6 Kim Horne CLA 2008-05-06 11:36:01 EDT
Fix in HEAD.