Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 94297 - [EditorMgmt] "Close All": Save Resources Dialog showing duplicates
Summary: [EditorMgmt] "Close All": Save Resources Dialog showing duplicates
Status: RESOLVED DUPLICATE of bug 17102
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-10 09:18 EDT by Benjamin Pasero CLA
Modified: 2005-05-11 09:35 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Pasero CLA 2005-05-10 09:18:52 EDT 
Version: 3.1.0
Build id: I20050509-2010

Steps to reproduce:
1.) Open a File twice in the Editor (Using Window > New Editor)
2.) Change something in the first Editor without Saving
3.) Call "Close All"

Actual Results:
The "Save Resources" Dialog shows up telling me that two resources are dirty. 

Expected Results:
The Dialog should only show one resource as dirty.

Regards,
Ben
Comment 1 Dani Megert CLA 2005-05-10 11:14:57 EDT 
It works if the same file is open in two different workbench windows.
Comment 2 Dani Megert CLA 2005-05-10 13:32:20 EDT 
Forget comment 1 - I was testing Exit which works fine in both cases.

Code similar to Workbench.saveAllEditors(boolean) needs to be added to
WorkbenchPage.closeAllEditors(boolean).

This should be fixed for 3.1.
Comment 3 Nick Edgar CLA 2005-05-10 14:35:21 EDT 
We eliminate dups in the dialog you get if there are dirty editors on shutdown,
but not this one.  Eliminating dups means that the workbench is assuming that
the editors have a shared document model, which is true for text editors in the
IDE but is not necessarily true in general.
But we should at least be consistent in our assumptions.
Comment 4 Randy Hudson CLA 2005-05-10 15:35:08 EDT 
See bug 17102 for more multiple prompting fun.
Comment 5 Dani Megert CLA 2005-05-10 17:54:37 EDT 
Maybe it's just me but to me it looks a bit strange to post a link which is 3
years old into a bug that's for a brand new feature and to which it is not
related ;-)
Comment 6 Douglas Pollock CLA 2005-05-11 09:35:29 EDT 
This is a duplicate of Bug 17102.  It's just became easier to trigger now.

*** This bug has been marked as a duplicate of 17102 ***