Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 93998 - [Editor Mgmt] [MPE] MultiPageEditorSite.registerContextMenu methods are inconsistent in whether they delegate
Summary: [Editor Mgmt] [MPE] MultiPageEditorSite.registerContextMenu methods are incon...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-06 16:20 EDT by Nick Edgar CLA
Modified: 2005-05-10 18:33 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-05-06 16:20:19 EDT 
build N20050505

In MultiPageEditorPartSite, the old registerContextMenu methods delegate to the
parent part, but the new ones (the ones with the boolean for editorInput) are
handled locally.

They should probably all work locally, but unfortunately this is contrary to the
spec.  Alternatively, the new ones should be changed to delegate to the parent.

It's not a great problem that they're not handled locally, as long as all parts
within the MPE use different ids.
Comment 1 Nick Edgar CLA 2005-05-06 16:20:53 EDT 
Doug, I'm assigning this to you just to comment.  I don't mind making the change.
Comment 2 Douglas Pollock CLA 2005-05-06 16:26:00 EDT 
I was aware of this problem when I committed the code, but wasn't sure what the
best approach might be.  Feel free to change it if you don't like it as it is.
Comment 3 Nick Edgar CLA 2005-05-09 11:09:50 EDT 
I've changed the new methods to work similarly to the old methods: they delegate
to the parent site.
Comment 4 Nick Edgar CLA 2005-05-09 11:10:02 EDT 
Fixed.
Comment 5 Nick Edgar CLA 2005-05-10 18:33:18 EDT 
Verified in I20050509-2010.