Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 93718 - [Workbench] XMLMemento loses text data on deserialization when createChild called before putText
Summary: [Workbench] XMLMemento loses text data on deserialization when createChild ca...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-04 17:03 EDT by Boris Bokowski CLA
Modified: 2005-05-13 13:29 EDT (History)
1 user (show)

See Also:

Attachments
proposed fix (743 bytes, patch)
2005-05-04 17:10 EDT, Boris Bokowski CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2005-05-04 17:03:52 EDT 
When you first create a child memento and then set the text data, as in:

mementoToSerialize.createChild("type","id");
mementoToSerialize.putTextData(textData);

the text data will no longer be there after serializing and then deserializing 
the memento.
Comment 1 Boris Bokowski CLA 2005-05-04 17:10:18 EDT 
Created attachment 20719 [details]
proposed fix
Comment 2 Boris Bokowski CLA 2005-05-04 17:40:07 EDT 
Nick, can you please review (and possibly commit) the fix?

The test class is attached to bug 93262.
Comment 3 Nick Edgar CLA 2005-05-05 11:15:30 EDT 
Patch reviewed and applied.  Thanks Boris.
Comment 4 Nick Edgar CLA 2005-05-05 11:15:55 EDT 
Fixed.
Comment 5 Nick Edgar CLA 2005-05-13 13:29:10 EDT 
Verified that the regression test XMLMemento.testPutTextDataWithChildrenBug93718
passes in I20050513-0010.