Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 92062 - [Decorators] Forground label decorator not working reliable
Summary: [Decorators] Forground label decorator not working reliable
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 96002 (view as bug list)
Depends on: 94760
Blocks:
  Show dependency tree
 
Reported: 2005-04-20 09:12 EDT by Martin Aeschlimann CLA
Modified: 2005-05-24 07:35 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (10.05 KB, image/png)
2005-04-20 09:13 EDT, Martin Aeschlimann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2005-04-20 09:12:55 EDT 
20050420

I configured the CVS outgoing changes to be decorated with a different forground
color.
Unfortunatly, that feature is not very reliable. All the time some elements keep
the normal forground even if the element is modified and that modification is
even decorated in the label (the star appended to the name).

I haven't a reproducable case at hand but I had caught it several times in the
debugger. The reason is not our special code in the package explorer: This one
now uses the viewers code to decorate and also gets the decorator event and
forwards it to the viewer.
Comment 1 Martin Aeschlimann CLA 2005-04-20 09:13:33 EDT 
Created attachment 20120 [details]
screenshot
Comment 2 Tod Creasey CLA 2005-04-29 16:21:10 EDT 
The problem here was a combination of adaptability and decorators. If the
adapted element got decorated first the colors and fonts were dropped - if not
they were kept - thats why it seems random.
Comment 3 Tod Creasey CLA 2005-04-29 16:32:52 EDT 
Fixed in build >20050429
Comment 4 Tod Creasey CLA 2005-05-10 13:10:17 EDT 
Reopening. These are not working anywhere currently
Comment 5 Tod Creasey CLA 2005-05-11 11:42:00 EDT 
We can't verify this as Bug 94760 needs to be fixed first.
Comment 6 Tod Creasey CLA 2005-05-11 12:02:04 EDT 
There was a second problem - if you set the foreground color we were using it to
propagate to the background.

Fixed in build >20050511.

Doug this one needs to go into our build submission
Comment 7 Tod Creasey CLA 2005-05-12 16:18:39 EDT 
Verified in 20050512
Comment 8 Tod Creasey CLA 2005-05-24 07:35:26 EDT 
*** Bug 96002 has been marked as a duplicate of this bug. ***