Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 9168 - [launcher] Task tray icon shows "javaw" when in collapsed mode
Summary: [launcher] Task tray icon shows "javaw" when in collapsed mode
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal with 3 votes (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 27395 41481 53859 86650 118707 152997 155797 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-02-06 10:28 EST by Nick Edgar CLA
Modified: 2007-02-14 16:42 EST (History)
23 users (show)

See Also:


Attachments
Eclipsed stacked icons (12.61 KB, image/png)
2007-02-14 09:27 EST, Jim Adams CLA
no flags Details
classic theme (6.12 KB, image/jpeg)
2007-02-14 10:24 EST, Andrew Niefer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-02-06 10:28:50 EST
Build 20020129

The task tray in Windows XP collapses multiple icons from the same app into a 
single icon with popup when space is needed.
When it does this for Eclipse, the name shown is "javaw".
It should give the product name.
Comment 1 Mike Wilson CLA 2002-02-06 14:38:42 EST
I agree that it should, but I don't know if this is possible. NE suggested 
that there might be an entry in the manifest which could help. SQ to 
investigate.
Comment 2 Mike Wilson CLA 2002-05-24 20:29:18 EDT
EIther because of a finger fumble or a bugzilla screwup, this never got 
assigned to SSQ. In any case, CC is looking at these issues now. 
Assigning PR to him.
Comment 3 Christophe Cornu CLA 2002-05-30 09:30:04 EDT
- Notes -
I have not found any manifest entry fixing this?
One possible fix requires starting the JVM through JNI within the same process 
as the launcher. This might be less flexible than current way (more dependency 
on JNI version, though JNI should be backward compatible).

This would also allow us to specificy that we want to use ComCtr6.0 for 
swt.dll (PR4789).
Comment 4 Christophe Cornu CLA 2003-02-12 13:57:38 EST
*** Bug 27395 has been marked as a duplicate of this bug. ***
Comment 5 Christophe Cornu CLA 2003-09-03 14:47:59 EDT
*** Bug 41481 has been marked as a duplicate of this bug. ***
Comment 6 Ed Burnette CLA 2005-01-10 17:28:37 EST
See bug 82518 for a possible solution.
Comment 7 Christophe Cornu CLA 2005-03-16 15:51:46 EST
*** Bug 86650 has been marked as a duplicate of this bug. ***
Comment 8 Steve Northover CLA 2005-04-11 21:26:54 EDT
The problem is that Windows looks in the executable for the icon to display in 
the task bar.  Since we don't own javaw.exe, we can't attach the necessary 
icon resource to that file.  If the VM was started through JNI, then the icon 
could be attached to the launcher (eclipse.exe).
Comment 9 Steve Northover CLA 2005-04-11 23:09:23 EDT
*** Bug 53859 has been marked as a duplicate of this bug. ***
Comment 10 Steve Northover CLA 2005-04-11 23:10:41 EDT
NOTE:  If we ever get this to work, we can embed the stupid XP manifest file 
in the exe like Windows wants, thus giving everyone the XP look at feel for 
free (which is what Microsoft should have done in the first place).
Comment 11 Steve Northover CLA 2005-12-02 08:59:42 EST
*** Bug 118707 has been marked as a duplicate of this bug. ***
Comment 12 Mark Melvin CLA 2006-02-22 10:10:17 EST
Any updates on this one?  It is in our bug system too. ;o)
Comment 13 Steve Northover CLA 2006-08-14 18:27:30 EDT
*** Bug 152997 has been marked as a duplicate of this bug. ***
Comment 14 Boris Bokowski CLA 2006-09-05 11:43:24 EDT
*** Bug 155797 has been marked as a duplicate of this bug. ***
Comment 15 Steve Northover CLA 2007-02-09 14:26:28 EST
Is this still happening?  It should not be because the name of the executable is no longer javaw.exe.  Also, with the advent of the new launcher. "we can embed the stupid XP manifest file in the exe like Windows wants".

Andrew?
Comment 16 Michael Giroux CLA 2007-02-09 14:40:23 EST
(In reply to comment #15)
> Is this still happening?  

Yes, it still happens using Eclipse 3.2.1.

> It should not be because the name of the executable
> is no longer javaw.exe.  Also, with the advent of the new launcher. "we can
> embed the stupid XP manifest file in the exe like Windows wants".
> Andrew?

Comment 17 Steve Northover CLA 2007-02-09 14:43:04 EST
It should no longer be happening in Eclipse 3.3 M5.  If it is, there is probably (finally) something we can do about it.
Comment 18 Andrew Niefer CLA 2007-02-09 14:56:52 EST
our .rc has:
#define ECLIPSE_ICON  401

#include "windows.h"
#include "winver.h"

ECLIPSE_ICON            ICON    DISCARDABLE     "eclipse.ico"
CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST "eclipse.exe.manifest" 

Steve, you mentioned before that that 401 is probably wrong.

Note that when the -vm argument points directly to a java(w).exe, we will still have the old behaviour.
Comment 19 Ed Burnette CLA 2007-02-12 09:14:23 EST
Bugzilla question: this is a fairly old bug so I'm wondering, should it still have a status of 'NEW'? According to https://bugs.eclipse.org/bugs/page.cgi?id=fields.html#status it seems like 'NEW' is a temporary state.
Comment 20 Steve Northover CLA 2007-02-12 12:19:04 EST
Not for us!
Comment 21 Jim Adams CLA 2007-02-14 09:26:31 EST
In 3.3M5 the Eclipse icons now stack without the java icon. However it is still not an eclipse icon. I will attach a picture. The icon used looks like generic MS icon.
Comment 22 Jim Adams CLA 2007-02-14 09:27:23 EST
Created attachment 58968 [details]
Eclipsed stacked icons
Comment 23 Steve Northover CLA 2007-02-14 09:56:30 EST
Ok, this ain't SWT any more.  We don't own either javaw.exe or eclipse.exe.  We CANTFIX this.
Comment 24 Steve Northover CLA 2007-02-14 09:58:55 EST
Ok, which component owns the splash screen? (Why don't I know this?)
Comment 25 Andrew Niefer CLA 2007-02-14 10:24:34 EST
Created attachment 58972 [details]
classic theme

does this depend on the theme at all?  For me, the stack now has the proper eclipse icon (classic theme).
Comment 26 Michael Giroux CLA 2007-02-14 10:32:35 EST
Using 3.3M5 the icons are correct for the stack entries, and for the taskbar entry.
Comment 27 Jim Adams CLA 2007-02-14 10:34:58 EST
I use the XP theme. Why would anyone want that clunky classic theme? :-)
Comment 28 Ron Baldwin CLA 2007-02-14 14:20:08 EST
Maybe a stale/corrupt icon cache?

To force Windows to rebuild it try one (or more) of these:
1. Change your color depth to something else and then back.
2. Use TweakUI: Repair > Rebuild Icons.
3. Delete %USERPROFILE%\Local Settings\Application Data\IconCache.db and reboot.
Comment 29 Jim Adams CLA 2007-02-14 15:07:32 EST
Seeing as how I just saw the icon change from the eclipse icon to the winzip icon I think you may be right about the icon cache.
Comment 30 Andrew Niefer CLA 2007-02-14 15:22:02 EST
Should we mark this as fixed?
Note that things are only fixed if we are using JNI to start eclipse.  Behaviour would be the same as before if java was started in a new process.
See http://wiki.eclipse.org/index.php/Equinox_Launcher#Finding_a_VM.2C_Using_JNI_Invocation_or_Executing_Java
for details on when JNI is used vs starting a new process.
Comment 31 Jim Adams CLA 2007-02-14 15:24:07 EST
I see that the -vm argument is passed a dll. If I were to pass the dll and the -vm argument, would it still work? Otherwise I am satisfied.
Comment 32 Andrew Niefer CLA 2007-02-14 15:44:50 EST
yes it would work.

Passing -vm with a java(w).exe would result in the old behaviour
Passing -vm with a jvm.dll, or a directory (jre/bin or jre/bin/client) would work the new way.
Comment 33 Jim Adams CLA 2007-02-14 15:47:05 EST
Thanks. I am ok with closing this.
Comment 34 Andrew Niefer CLA 2007-02-14 16:42:46 EST
marking as fixed in M5