Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 88905 - Preference import and export wizards should advocate use of .epf extension
Summary: Preference import and export wizards should advocate use of .epf extension
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: shujie liao CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-23 13:56 EST by Michael Van Meekeren CLA
Modified: 2005-06-10 13:07 EDT (History)
0 users

See Also:

Attachments
add ".epf" for export file (2.65 KB, patch)
2005-06-07 13:06 EDT, shujie liao CLA 		no flags Details | Diff
Patch 1of 3 (2.04 KB, patch)
2005-06-08 13:27 EDT, shujie liao CLA 		no flags Details | Diff
Patch 2of 3 (4.20 KB, patch)
2005-06-08 13:28 EDT, shujie liao CLA 		no flags Details | Diff
Patch 2of 3 (4.20 KB, patch)
2005-06-08 13:28 EDT, shujie liao CLA 		no flags Details | Diff
Patch 3 of 3 (1.87 KB, patch)
2005-06-08 13:29 EDT, shujie liao CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA 2005-03-23 13:56:49 EST 
That support has been lost since moving from the pref dialog to wizard

   /**
     * The default extension for preferences files.
     */
    protected static final String PREFERENCE_EXT = ".epf"; //$NON-NLS-1$
Comment 1 Michael Van Meekeren CLA 2005-03-23 14:31:19 EST 
Here's the old code


	/**
	 * Return the file name setting or a default value if there isn't one.
	 * 
	 * @param export
	 *            <code>true</code> if an export file name is being looked
	 *            for.
	 * 
	 * @return String if there is a good value to choose. Otherwise return
	 *         <code>null</code>.
	 */
	private String getFileNameSetting(boolean export) {

		String lastFileName = WorkbenchPlugin.getDefault().getDialogSettings().get(
				WorkbenchPreferenceDialog.FILE_PATH_SETTING);
		if (lastFileName == null) {
			if (export)
				return System.getProperty("user.dir") + System.getProperty("file.separator")
+ WorkbenchMessages.ImportExportPages_preferenceFileName +
AbstractPreferenceImportExportPage.PREFERENCE_EXT; //$NON-NLS-1$//$NON-NLS-2$

		} else if ((export) || (new File(lastFileName).exists())) {
			return lastFileName;
		}

		return null;
	}
Comment 2 Michael Van Meekeren CLA 2005-03-23 14:32:21 EST 
   /**
     * The accepted extensions for the file chooser dialog.
     */
    public static final String[] DIALOG_PREFERENCE_EXTENSIONS = new String[] {
            "*" + PREFERENCE_EXT, "*.*" }; //$NON-NLS-1$ //$NON-NLS-2$
Comment 3 Michael Van Meekeren CLA 2005-05-27 18:04:24 EDT 
Shujie why were you removing the target milestone from this.
Comment 4 shujie liao CLA 2005-05-30 11:51:59 EDT 
What I considered was moving all unresolved bugs for RC1 to RC2 since The 
deadline for RP1 has past. Sorry I'm not sure how to process changing the 
target milestones. I think I should talk with you or nick before I did.
Comment 5 Tod Creasey CLA 2005-06-02 15:02:44 EDT 
MVM should this still be RC2?
Comment 6 Michael Van Meekeren CLA 2005-06-02 15:22:44 EDT 
yes
Comment 7 shujie liao CLA 2005-06-07 13:06:54 EDT 
Created attachment 22525 [details]
add ".epf" for export file 

add "*.*" to file browser dialog and extension ".epf" for export file
Comment 8 shujie liao CLA 2005-06-08 13:27:18 EDT 
Created attachment 22621 [details]
Patch 1of 3

Apply from:
/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardPage.java
Comment 9 shujie liao CLA 2005-06-08 13:28:22 EDT 
Created attachment 22622 [details]
Patch 2of 3

Apply from:
org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/WizardArchiveFileResourceExportPage1.java
Comment 10 shujie liao CLA 2005-06-08 13:28:29 EDT 
Created attachment 22623 [details]
Patch 2of 3

Apply from:
org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/WizardArchiveFileResourceExportPage1.java
Comment 11 shujie liao CLA 2005-06-08 13:29:30 EDT 
Created attachment 22624 [details]
Patch 3 of 3

Apply from:
org.eclipse.ui.workbench/Eclipse
UI/org/eclipse/ui/internal/wizards/preferences/
Comment 12 Michael Van Meekeren CLA 2005-06-08 14:16:19 EDT 
fixed in HEAD
Comment 13 shujie liao CLA 2005-06-10 12:57:56 EDT 
Varified in Build 20050609-0010
Comment 14 shujie liao CLA 2005-06-10 13:07:14 EDT 
Varified (again)in Build id: I20050610-1200