Bug 88345 - [ViewMgmt] [RCP] Can close a non-closable view when docked on fastviewbar
Summary: [ViewMgmt] [RCP] Can close a non-closable view when docked on fastviewbar
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Paul Webster CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-17 11:29 EST by Robert Farr CLA Friend
Modified: 2005-11-14 11:28 EST (History)
4 users (show)

See Also:

Attachments
Check view is closeable (2.39 KB, patch)
2005-08-30 13:22 EDT, Paul Webster CLA Friend 		no flags Details | Diff
Check view is closeable v02 (3.17 KB, patch)
2005-08-30 14:28 EDT, Paul Webster CLA Friend 		no flags Details | Diff
fast view test (6.56 KB, patch)
2005-08-30 14:30 EDT, Paul Webster CLA Friend 		no flags Details | Diff
fast view test v02 (6.68 KB, patch)
2005-08-30 14:52 EDT, Paul Webster CLA Friend 		no flags Details | Diff
Check view is closeable v03 (3.18 KB, patch)
2005-08-30 14:53 EDT, Paul Webster CLA Friend 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Farr CLA Friend 2005-03-17 11:29:22 EST 
* Create a workspace with a non-closable view, that is movable
* Drag view and dock on FastView
* Right click on icon in fastview and click "Close"
Comment 1 Nick Edgar CLA Friend 2005-05-06 16:25:12 EDT 
Stefan, could you please look into this one?
Comment 2 Stefan Xenos CLA Friend 2005-05-13 12:59:25 EDT 
No time for 3.1.
Comment 3 Nick Edgar CLA Friend 2005-06-13 12:31:15 EDT 
See also bug 99723.
Comment 4 Paul Webster CLA Friend 2005-08-30 13:22:46 EDT 
Created attachment 26644 [details]
Check view is closeable

The fast view context menu is created in the
FastViewBarContextMenuContribution.  It just needed to enable the close menu
item by checking if the view was closeable.

PW
Comment 5 Paul Webster CLA Friend 2005-08-30 14:28:58 EDT 
Created attachment 26646 [details]
Check view is closeable v02

Enable the close menu item only if the view is closeable.  It also includes
some testable API.

PW
Comment 6 Paul Webster CLA Friend 2005-08-30 14:30:01 EDT 
Created attachment 26647 [details]
fast view test

The tests the menu item for a closeable fast view and a non-closeable fast
view.

Doug, could you please take a look at this?  It's a really short fix.

PW
Comment 7 Paul Webster CLA Friend 2005-08-30 14:52:34 EDT 
Created attachment 26648 [details]
fast view test v02

Minor update to test.

PW
Comment 8 Paul Webster CLA Friend 2005-08-30 14:53:07 EDT 
Created attachment 26649 [details]
Check view is closeable v03

Patch with null check for WorkbenchPage.

PW
Comment 9 Douglas Pollock CLA Friend 2005-08-30 15:46:26 EDT 
I added some since tags, formatted a block of code and remove an extraneous 
format change to some javadoc.  Tests pass on both 3.1.1 and 3.2.  Code has 
been committed to both streams.
Comment 10 Nick Edgar CLA Friend 2005-08-30 21:08:22 EDT 
Thanks Paul and Doug.
Comment 11 Paul Webster CLA Friend 2005-09-20 11:53:10 EDT 
verified in 3.2
Comment 12 Michael Van Meekeren CLA Friend 2005-11-14 11:28:08 EST 
The test for this bug is running as a performance test and was not ported back
to 3.1 tests, is this intentional?  I.e. not ported and running as a performance
test at all?

see bug 116261 Performance Tests Failing: bug 88345 test failing