Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 88311 - [jars] RelEng tests assume directory structure
Summary: [jars] RelEng tests assume directory structure
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-17 06:36 EST by DJ Houghton CLA
Modified: 2005-03-18 14:00 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2005-03-17 06:36:38 EST 
The RelEng test suites that verify the structure of a build assume that we are
dealing with non-JAR'd plug-ins. This is no longer correct and can cause a NPE
to happen. 

http://fullmoon.ottawa.ibm.com/downloads/drops/N20050317-0010/testresults/html/org.eclipse.releng.tests_winxp.html

Specifically see the following method for problems:
   org.eclipse.releng.tests.BuildTests#testDirectory

Let me know if you need help.
Comment 1 DJ Houghton CLA 2005-03-18 08:50:33 EST 
Looking at last night's test results, I think that BuildTests#testPluginFiles
needs to be changed.

A check was added to only test the plug-in if it is a directory but that's not
good enough. The algorithm should be something like:

- get a dir list
- if the entry is a directory then verify and add to list
- if the entry is a JAR then verify and add to the list

I don't think that JAR'd plug-ins are currently added to the list. 

Depending on what you are looking for, you should be able to use the
java.util.zip classes to look for files, etc.

Let me know if you would like a hand with this.
Comment 2 Sonia Dimitrov CLA 2005-03-18 14:00:51 EST 
Fix released for builds > 200503181400.