Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 87990 - [Contributions] SubContributionManager.remove(String) calls itemRemoved on the wrapper, not the original item
Summary: [Contributions] SubContributionManager.remove(String) calls itemRemoved on th...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-14 16:36 EST by Nick Edgar CLA
Modified: 2009-04-28 08:59 EDT (History)
1 user (show)

See Also:

Attachments
Patch to apply early in M7 (3.84 KB, patch)
2005-03-23 11:52 EST, Nick Edgar CLA 		no flags Details | Diff
Respun patch (3.27 KB, patch)
2009-04-20 14:37 EDT, Paul Webster CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-03-14 16:36:05 EST 
3.1M5

While making the changes for bug 80569, I noticed that
SubContributionManager.remove(String) calls itemRemoved on the item found on the
parent manager.  But this is the wrapped object, not the original item added to
the SubContributionManager.  Need to unwrap it first.
Comment 1 Nick Edgar CLA 2005-03-14 16:37:18 EST 
Actually, it was bug 81312.
Comment 2 Nick Edgar CLA 2005-03-14 16:37:49 EST 
Fix to SubContributionManager released.
Comment 3 Douglas Pollock CLA 2005-03-14 18:17:09 EST 
This fix caused ConcurrentModificationExceptions, and so I backed it out for the
integration build.  If you can't reproduce the exceptions, let me know....
Comment 4 Nick Edgar CLA 2005-03-23 11:52:22 EST 
Created attachment 19119 [details]
Patch to apply early in M7
Comment 5 Nick Edgar CLA 2005-05-06 11:20:44 EDT 
Deferring.
Comment 6 Michael Van Meekeren CLA 2006-04-21 13:56:39 EDT 
Moving Dougs bugs
Comment 7 Paul Webster CLA 2007-04-05 19:04:04 EDT 
Assigning to component owner
PW
Comment 8 Paul Webster CLA 2009-04-20 14:37:25 EDT 
Created attachment 132474 [details]
Respun patch
Comment 9 Paul Webster CLA 2009-04-20 14:38:10 EDT 
Released to HEAD >20090420
PW
Comment 10 Paul Webster CLA 2009-04-28 08:59:35 EDT 
In I20090428-0100
PW