Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 87826 - Need to improve image loading in Workbench
Summary: Need to improve image loading in Workbench
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: nl, performance
Depends on:
Blocks: 87779
  Show dependency tree
 
Reported: 2005-03-11 16:10 EST by Tod Creasey CLA
Modified: 2005-03-30 11:46 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2005-03-11 16:10:11 EST 
The Workbench image loading has several issues

1) The string "icons/full" is all over the place in the UI and should be made a
constant
2) This needs to be prepended by /nl
3) The plugin descriptor is still in use to load images. This does not support
nl which is required for BIDI support
Comment 1 Tod Creasey CLA 2005-03-11 16:21:04 EST 
This has been fixed in build >20050311.

We ship 257 images in the ide and workbench of which all but 8 were loaded using
 new instances of the string so this saves 254 strings.
Comment 2 Tod Creasey CLA 2005-03-11 16:28:59 EST 
The number is actually 77 - there are several calls to these methods that are no
longer in use but need to remain for API reasons.

Another note is that we actually only create about 20 on a typical starup - you
have ti hit most everything to get a number this high.
Comment 3 Tod Creasey CLA 2005-03-30 11:46:48 EST 
Verified in 20050330