Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 86808 - No Preview for refactoring available
Summary: No Preview for refactoring available
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal with 2 votes (vote)
Target Milestone: 1.5 M5   Edit
Assignee: Phillip Avery CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 105633 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-02-28 03:11 EST by Christian Schweer (only bugzilla-mails accepted) CLA
Modified: 2006-11-28 15:59 EST (History)
2 users (show)

See Also:

Attachments
Screenshot of the missing preview (13.64 KB, image/png)
2005-02-28 03:13 EST, Christian Schweer (only bugzilla-mails accepted) CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Schweer (only bugzilla-mails accepted) CLA 2005-02-28 03:11:39 EST 
eclipse-3.1M5 & webtools-1.0M3 on WinXP

Whenever renaming a Java class, that is imported by JSP-pages, with
JDT-Refactor, I don't get a preview for the changes in the JSP-Pages.
The Preview window just states "No preview available".

The refactoring itself works with out problems.
Comment 1 Christian Schweer (only bugzilla-mails accepted) CLA 2005-02-28 03:13:21 EST 
Created attachment 18350 [details]
Screenshot of the missing preview

Added screenshot of the refactoring window
Comment 2 David Williams CLA 2005-06-15 01:21:34 EDT 
Changed Version field given new release numbering.
Comment 3 Phillip Avery CLA 2005-07-06 16:32:11 EDT 
Raising priority. I think this should be fixed for 0.7.
Comment 4 David Williams CLA 2005-07-19 18:34:04 EDT 
As we discussed, I think too late for .7, so am changing priority back to 3. 
Important, but we need to shut down.
Comment 5 Phillip Avery CLA 2005-08-03 16:06:34 EDT 
*** Bug 105633 has been marked as a duplicate of this bug. ***
Comment 6 Phillip Avery CLA 2005-11-03 13:43:04 EST 
I see the problem.

It's because CompositeChange isn't a subclass of TextChange.

All of the JSPRefactoring participants return a composite change.
We can change it to return a DocumentChange with a MultiEdit.

It seems to fix it.  Still no highlighting though.
Comment 7 Phillip Avery CLA 2005-11-03 15:44:34 EST 
OK I was mistaken.

BasicRefactorSearchRequestor#RenameChange

didn't implement "getPreviewDocument()".
I'm testing this approach now.
Comment 8 Phillip Avery CLA 2005-11-07 19:01:41 EST 
It's a one method change.

Tested and checked into HEAD.
Comment 9 David Williams CLA 2006-03-04 01:04:52 EST 
This change is a bulk update of all _un_targeted, fixed, resolved bugs upon release of M5. This particular bug _might_ have been fixed earlier than M5. (Feel free to correct).
Comment 10 John Lanuti CLA 2006-11-28 15:59:37 EST 
This is part of a mass update to close out all stale WTP resolved bugs from the 1.0.x and 1.5.0 timeframe.  If you feel this bug was closed inappropriately, please reopen.

Thanks, John Lanuti