Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 86223 - Mark Occurrences feature
Summary: Mark Occurrences feature
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Kevin Barnes CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-22 20:47 EST by Chris Noe CLA
Modified: 2005-03-14 15:14 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Noe CLA 2005-02-22 20:47:05 EST
The Java editor can highlight the occurrences of the currently selected symbol
throughout the editor. The scrollbar lights up the relative locations, and
clicking one takes you to the spot.

All of the symbol types mentioned in the Open Declaration enhancement (84694)
would benefit greatly from this - but especially: properties, ids, targets,
(including within depends).

Mark Occurences was mentioned along with other features in 80135. I am entering
it separately here to hopefully generate some focused discussion.
Comment 1 Darin Swanson CLA 2005-02-22 20:52:49 EST
Thought for sure we had a bug for this already...but I can't find it.

Time permitting...something that might be good to tackle with the JDT Text 
guys in a committer sprint at EclipseCon.
Comment 2 Darin Swanson CLA 2005-03-08 15:59:06 EST
Coming soon to a build near you...
Comment 3 Darin Swanson CLA 2005-03-14 14:36:22 EST
I have this implemented.
It is more a chunk of code than I anticipated so I believe we should do some 
initial verification and then log any remaining issues on smaller resolution.

Changes to:
AntEditor: all the wiring for installing/uninstalling/triggering the 
occurrences
AntEditorActionContributor: adds the toggle mark occurrences action
OccurrencesFinder: new class that does the work of finding occurrences
AntEditorActionMessages.properties: new action nls'ing
ToggleMarkOccurrencesAction: the new action
AntUIImages: declare the new image
IAntUIConstants: new constante for the new image
AntElementNode: default implementations for all of the occurrence finding
AntModel: adds the computeIdentifierOffset method
AntProjectNode: matches occurrence against the default target name and returns 
a modified identifier for correct positioning within the project declaration
AntPropertyNode: node checks for occurrences in its value if the value 
references a property, returns its identifier (property name)
AntTargetNode: node checks for occurrences in the dependency listings and 
returns its occurences identifier (the target name)
AntTaskNode: node checks for occurrences in its text data
AntEditorPreferenceConstants: toggle mark occurrences constants
AntEditorPreferencePage: expose the toggle mark occurrences preferences to the 
user
AntPreferenceMessages.properties: new nls strings
plugin.properties: nls
plugin.xml: command and key binding and the action set and part association 
for the toggle mark occurences action
icon reorg and addition for the new action icons
Comment 4 Darin Swanson CLA 2005-03-14 14:36:48 EST
Please verify Kevin.
Comment 5 Kevin Barnes CLA 2005-03-14 15:14:39 EST
verified