Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 86191 - config.ini from rcp browser example incomplete
Summary: config.ini from rcp browser example incomplete
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 89663
Blocks:
  Show dependency tree
 
Reported: 2005-02-22 14:34 EST by Pascal Rapicault CLA
Modified: 2005-04-01 17:26 EST (History)
1 user (show)

See Also:


Attachments
Browser.product file (1.33 KB, application/octet-stream)
2005-04-01 17:21 EST, Nick Edgar CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2005-02-22 14:34:40 EST
Due to the introduction of org.eclipse.core.commands in the ui stack, the
confi.ini shipped with the browser example is incorrect.
Comment 1 Nick Edgar CLA 2005-02-23 09:24:25 EST
I assume you mean the various platform-specific config.ini's in project source.
Or do you mean the built binary one (which only works against 3.0[.1]).

Any suggestions for reducing this to a single cross-platform config.ini (without
use of o.e.update.configurator)?  Now that bundle manifests can have
platform-specific filters, could we just list all SWT fragments?
Comment 2 Nick Edgar CLA 2005-03-30 14:58:58 EST
I'm considering just providing a product definition file, and deleting the .ini
files.
Comment 3 Nick Edgar CLA 2005-03-30 15:00:54 EST
Unfortunately, that has the same problem of having to list all the
platform-specific fragments, so apparently I'd still need a different file for
each platform.

The browser example doesn't currently use features.  Maybe it should.
But I'd still like it to be able to run without update.configurator.
Comment 4 Wassim Melhem CLA 2005-03-30 15:11:04 EST
One possibility would be for you to list all the fragments in the .product 
file, and when PDE is building the product and generating the (default, not 
custom) config.ini file for you, we only list the fragments that match your 
current environment.
Comment 5 Nick Edgar CLA 2005-03-30 15:27:12 EST
So PDE processes the Eclipse-PlatformFilter attributes in the manifest as well
as the runtime?  Will try.
Comment 6 Wassim Melhem CLA 2005-03-30 15:31:00 EST
We certainly pass the plugins through the platform filter before we build them.

However, if you have a custom config.ini file, we leave it untouched.  
Also, when we generate the default config.ini, I think we still put everything 
on the osgi.bundles line.

In any event, I think it's best to let PDE take care of you in this 
situation.  If there is tweaking that needs to be done, we'll do it.
Comment 7 Nick Edgar CLA 2005-03-30 15:39:42 EST
OK.  I can't actually export right now due to bug 89663, but will try when
that's fixed.
Comment 8 Nick Edgar CLA 2005-04-01 17:20:14 EST
I've added a Browser.product file and deleted the other config.ini files.
Comment 9 Nick Edgar CLA 2005-04-01 17:21:18 EST
Created attachment 19470 [details]
Browser.product file

Wassim, could you scan this, and let me know if you think it looks OK?
I'm including all SWT fragments in it.
Comment 10 Wassim Melhem CLA 2005-04-01 17:26:42 EST
It looks good, and as requested, please do not include a custom config.ini 
anymore.

At minimum, I will make sure that:
if you are exporting to a particular ws-os-arch combination, I don't include 
the extraneous fragments in the config.ini

Luxury:
if we have time to support simultaneous multiple platform exports (in the 
presence of the delta pack), that the list of plugins is adjust per os-ws-arch 
run.