Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 85153 - [RCP] Product Configuration Editor clashing with export
Summary: [RCP] Product Configuration Editor clashing with export
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-14 11:28 EST by Ed Burnette CLA
Modified: 2005-03-16 20:18 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Burnette CLA 2005-02-14 11:28:25 EST
I20050209
The user creates an RCP program plug-in project. Now he wants to create a
package for deployment. First thing he tries is he right clicks on the project
and selects Export. It's not obvious what to select from here but let's say he
picks Deployable plug-ins and fragments. He sepects a Zip file format, and saves
the export operation as an Ant build script. That partially works but this way
he will not discover the Product Configuration editor, which has very similar
functionality but is invoked very differently. These stories need to be unified.

(Other things the user might have reasonably picked from the current list are
Deployable features or Archive file. Neither of these is correct either.)
Comment 1 Ed Burnette CLA 2005-02-16 22:33:28 EST
I have an idea about how to address this. Perhaps this is what you're planning
anyway, I don't know.

In the Plug-in Manifest editor, on the first page you have a little exporting
section that refers you to the Export Wizard. How about if Products worked the
same way. Instead of having exporting be part of the editor, delegate it to a
product exporting wizard. The wizard would take its input from the .product file
(icons and so forth) and have additional options about where to export, what
form to export in, and optionally where to put an ant script, just like the
deployable plug-ins export wizard today.
Comment 2 Wassim Melhem CLA 2005-02-16 22:52:58 EST
what is the point of a wizard that will have a duplicate (albeit a subset) of 
content of the editor?
Comment 3 Ed Burnette CLA 2005-02-17 00:10:45 EST
No, no, I was thinking there would not be any duplication in the content. The
editor would not say where to export to or the format, it would just describe
the product itself (name, plug-ins and/or features, splash, icons, and so forth).
Comment 4 Wassim Melhem CLA 2005-02-17 00:14:08 EST
sounds reasonable.  I find the idea of keeping all the build settings out of 
the product file attractive, especially since the export format list are 
likely to grow soon.
Comment 5 Wassim Melhem CLA 2005-02-17 00:15:45 EST
If we do that, then step 1 (the synchronization portion) would be done at the 
same time.
Comment 6 Wassim Melhem CLA 2005-02-17 00:21:26 EST
Nick/Jeff, +/- 1?
Comment 7 Wassim Melhem CLA 2005-02-17 00:22:10 EST
forgot to actually cc Nick
Comment 8 Jeff McAffer CLA 2005-02-17 09:53:51 EST
Sounds reasonable.  My assumptoin here is that all plugin related exporting 
(features, plugins, products, ...) will go through the same/similar wizard.  
This gives users the "full power"(tm) to choose if they want signing, jnlp, 
zipped, update site, ... (the last ones assume we do some other work but you 
get the idea).  so if that is a reasonably accurate description then +1

Note also should be able to right click on a .product file and export
Comment 9 Wassim Melhem CLA 2005-02-17 10:09:24 EST
that's what I had in mind, yes.  consistency between all exports would be good.
Comment 10 Nick Edgar CLA 2005-02-17 12:34:46 EST
Being consistent in the use of export wizards for export would be good. 
However, the export options can be complex, and the user should not have to
re-enter these each time.  This will definitely be an iterative process.  If the
settings can be captured in the product file, even if presented in the wizard,
that would be good.  A link from the product editor to the export wizard (not
just descriptive text) would be nice.
Comment 11 Wassim Melhem CLA 2005-02-17 12:41:50 EST
"If the settings can be captured in the product file, even if presented in the 
wizard,"

captured, but not displayed in the editor UI, right?  Otherwise, we would have 
the duplication I was trying to avoid (comment 2)
Comment 12 Nick Edgar CLA 2005-02-17 13:12:49 EST
Yes, I'm fine with that, as long as it's clear which product definition is
affected by the wizard.
Comment 13 Ed Burnette CLA 2005-02-17 13:30:45 EST
I can see a need for remembering and reusing export configuration options but
why does it need to be stored in the .product file? I see .product as being kind
of like .project, it describes a thing. Exports are more like launch
configurations, they describe what to do with the thing.

...
Would it be practical to use an ant script as the export configuration
persistance format? You already have another request to create them from the UI,
so why store it twice?
Comment 14 Jeff McAffer CLA 2005-02-17 20:39:35 EST
First cut storing them in the .product file would be fine if that's easier.

Storing the data in a separate file has benefits.  There is precedence for this 
in the Jar export .jardesc files.  The worry here is that it just 
introduces "yet another file" to quote Wassim.

Saving as a build script does not seem like much fun.  What happens when the 
user wants to open it and change one value?!  reverse engineer the script and 
replace values?

Other consideration is the password optionally required for signing.  Probably 
have to enter that every time.

You know, I'm thinking that there aren't all that many values to enter so 
perhaps just saving them in the dialog settings store is ok.  I use Export 
quite a bit and the behaviour is not bad.  Depends of course if you are 
switching around a lot bu tif you are exporting pretty much the same 
thing/style all the time there is little to change.

Suggest we do as little as possible here and see what the useabilty is like.
Comment 15 Wassim Melhem CLA 2005-03-15 01:26:12 EST
There is now an Eclipse Product which can be invoked from the product editor 
itself.

It will also appear in the Export Wizard list (i.e File > Export...)

the wizard has more output formats and will have even more options for M6.
Comment 16 Ed Burnette CLA 2005-03-16 20:18:05 EST
Cool, thanks.