Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 84255 - [ActivityMgmt] Define trigger points in schema
Summary: [ActivityMgmt] Define trigger points in schema
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 80130
  Show dependency tree
 
Reported: 2005-02-02 13:55 EST by Kim Horne CLA
Modified: 2005-03-30 11:15 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2005-02-02 13:55:00 EST
Trigger point should be defined in XML.  When code that implements a trigger
point is used it should access a central source in workbench to see if the
trigger point should be honoured.  In this way products can define policy for
trigger points (ie: disable the import/export wizard from being a trigger point).
Comment 1 Kim Horne CLA 2005-02-23 08:44:05 EST
Schema files for trigger points have been checked in.
(org.eclipse.ui/schema/activitySupport.exsd).  Implementation forthcoming.
Comment 2 Kim Horne CLA 2005-02-23 10:10:55 EST
Nick, I have RCP concerns regarding this bug.  What should be the default
behaviour of a trigger point in an RCP app?  Should they get the prompting
dialog that's currently present in the workbench for free?  The alternative is
that they get a basic advisor that just enables activities without prompting.
Comment 3 Nick Edgar CLA 2005-02-23 10:38:54 EST
I think the default prompting behaviour would be fine, as long as the app can
override it.  Matt, do you have any concerns here?
Comment 4 Kim Horne CLA 2005-02-23 10:45:10 EST
Current RCP apps will get the dialog so perhaps it's best for us to keep using
it if only for that reason.
Comment 5 Kim Horne CLA 2005-02-24 11:19:22 EST
Initial implementation in head.  Included is support for custom TriggerPoint
advisors.  The default for workbench is essentially what we have now (the
dialog).  The provided implementation for the SDK is similar, except that the
strings have been tweaked such that "Activities" are "Capabilities". 

Trigger point definitions themselves are currently ignore.  The next step is to
implement the trigger point registry and map out our existing trigger points.
Comment 6 Kim Horne CLA 2005-03-11 12:11:26 EST
Trigger point definitions for workbench and IDE have been created along with the
trigger point registry code.
Comment 7 Kim Horne CLA 2005-03-30 11:15:03 EST
Verified in I20050330-0500