Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 84189 - Remove "final" limitation from Launch implementation
Summary: Remove "final" limitation from Launch implementation
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.1 M5   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-01 17:20 EST by Jared Burns CLA
Modified: 2005-02-07 11:15 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2005-02-01 17:20:53 EST 
Our public implementation of ILaunch (org.eclipse.debug.core.Launch) declares a
number of methods as final. This keyword puts an unnecessary burden on extenders
and I'd like to remove it.

For example, I want to override the canTerminate() method to allow the user to
terminate a launch before any debug targets or processes have been added. I
should be able to simply override this method, but because of the "final"
declaration I'd have to write a messy wrapper to do this.

Clients shouldn't have to care whether or not we think overriding a method is a
great idea. We can't possibly know all the situations which might cause a
developer to want to override a method. By using the "final" keyword, a client's
implementations is limited by the original developer's imagination at a point in
time.
Comment 1 Jared Burns CLA 2005-02-04 12:40:25 EST 
Fixed in Launch. This change gives clients (and ourselves) much more breathing
room when subclassing Launch.

Please verify, DW.
Comment 2 Darin Wright CLA 2005-02-07 11:15:38 EST 
Verified.