Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 81986 - [Intro] BIDI:Welcome window is LTR aligned on Arabic platform
Summary: [Intro] BIDI:Welcome window is LTR aligned on Arabic platform
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 critical (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Mazen Faraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-29 06:30 EST by Emad Al-Agouz CLA
Modified: 2005-10-03 11:47 EDT (History)
5 users (show)

See Also:


Attachments
OverviewPage (567.77 KB, image/bmp)
2005-02-09 07:18 EST, Emad Al-Agouz CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emad Al-Agouz CLA 2004-12-29 06:30:30 EST
Tested on Win2K Arabic default locale, build eclipse-SDK-3.1M3-win32 with 
Arabic Translation Fragments and launched with rtl direction.

Welcome page and the overview page are left aligned
Comment 1 Emad Al-Agouz CLA 2004-12-29 07:02:00 EST
Please adjust the right alignment and the reading order of the welcome and 
overview page
Comment 2 Konrad Kolosowski CLA 2004-12-29 12:36:46 EST
This is intro.
Comment 3 Emad Al-Agouz CLA 2005-02-09 07:18:26 EST
Created attachment 17781 [details]
OverviewPage

Same behaviour with the what's new , Tutorial and Sample pages
Comment 4 Jonathan Simpson CLA 2005-02-09 10:40:38 EST
Any progress on this bug?  The NLS team needs to evaluate BIDI's status.
Comment 5 Mazen Faraj CLA 2005-02-09 11:59:55 EST
investigating....
Comment 6 Mazen Faraj CLA 2005-02-09 12:30:15 EST
what CSS is being used? did you guys change the base platform CSS when 
translating to arabic? 
also, can you attach a gif of the expected results for the overview page? 
ps: I can read arabic. 
 
Comment 7 Mazen Faraj CLA 2005-02-09 16:54:25 EST
the plaform base CSS needs to be updated to enable displaying bi-di languages 
correctly.
will investigate more. 
fyi: this can not be fixed in time for M5.
  
Comment 8 Cam-Thu Le CLA 2005-02-10 11:31:05 EST
Any immediate build after M5 is OK, but it should prior to M6. Please make sure 
Emad know the build to test with. Thank you.  
Comment 9 Emad Al-Agouz CLA 2005-03-16 08:23:59 EST
Please take the appropriate action to resolve this defect as soon as 
possible...Thank you
Comment 10 Mazen Faraj CLA 2005-03-31 11:54:31 EST
There are two parts to this defect.
1) The support that the intro framwrok gives to enable translating intro 
content easily. 
2) Using that support to modify the SDK intro pages to look appropriate on 
BiDi machines.

Issue 1 is resolved in M6. The intro support always enabled dropping 
translated files in an nl fragment, and running nl'ed.
The problem was that relative resources in the intro pages needed to be 
resolved properly. And there needed a way to drop a delta to a file as opposed 
to a full file. This is because if you copied a CSS file that had relative 
links to icons, for example, you need to copy the icons as well to the 
fragment. 

The solution now is as follows. To NL an intro plugin, you have to drop in the 
fragment all translated files. For CSS and resources, if a CSS needs to be 
changed for a given locale, the resources pointed to by that CSS file also 
need to be in the fragment. To aviod this, the style and atl-style attributes 
in the intro markup now support multiple CSS files. That is, you can now write:
<page style="root.css,root_delta.css" ...> 

This solves the problem as follows:
if you need to modify root.css for arabic (which we do) then you simply change 
the style attribute of the root page in the introContent.xml, and add 
root_delta.css. This way you modify the look for arabic, without the need to 
copy any resources because now the delta css has no resource references.

To resolve issue 2) you have to modify the CSS for the SDK intro to give a 
mirro image of the Englsh SDK. ie: to make it rtl. 

I am half way done with this CSS redesign and I am opening a different bug for 
modifying CSS into RTL. 

This defect is only for Intro support to enable that.  



 






 
Comment 11 Mazen Faraj CLA 2005-04-04 15:58:09 EDT
opened defect 90221 to track making CSS rtl in SDK. 

closing this defect as it should have been closed to M6. 

please track the new defect.