81644 – [Preferences] PreferenceDialog.okPressed should not close dialog on error

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 81644 - [Preferences] PreferenceDialog.okPressed should not close dialog on error

Summary: [Preferences] PreferenceDialog.okPressed should not close dialog on error

Status:	RESOLVED DUPLICATE of bug 75988

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.0.1
Hardware:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assignee:	Tod Creasey
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-12-20 09:28 EST by Jamie Beznoski
Modified:	2005-01-05 15:09 EST (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jamie Beznoski

2004-12-20 09:28:42 EST

PreferenceDialog.okPressed() always closes the dialog.  To improve UI 
behaviour, this should not happen if one of the PreferencePages within returns 
false from its performOk() method.  

What I mean by that is: if an error occurs validating or saving data on a 
preference page (indicated by the preference page returning false), the 
PreferenceDialog should remain open or the page that caused an error, with the 
error dialog centered over the PreferenceDialog.  The dialog should then 
remain open so the user can address the error without having to re-open the 
dialog.

I'm working around this for now by extending PreferenceDialog, but it would be 
nice if either:
a) the dialog stays open when one of its pages returns false from its performOk
() method
b) this behaviour can be customized, for example, by means of a setCloseOnError
(boolean) method

Comment 1 Tod Creasey

2005-01-05 15:09:23 EST


*** This bug has been marked as a duplicate of 75988 ***