Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 79564 - Add tracing support to all layers for data collection and communication components
Summary: Add tracing support to all layers for data collection and communication compo...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 2000
: P1 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Andy Kaylor CLA
QA Contact:
URL: http://www.eclipse.org/tptp/groups/Ar...
Whiteboard: closed460
Keywords:
: 97159 (view as bug list)
Depends on: 93153 93154 93155
Blocks:
  Show dependency tree
 
Reported: 2004-11-26 10:49 EST by Christine Knight CLA
Modified: 2016-05-05 11:02 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christine Knight CLA 2004-11-26 10:49:39 EST
Users of the RAC/agent communication layer have complained that there is no 
tracing support to help with debugging communication problems between the RAC 
and agent. This tracing support should be added so that it can be turned on at 
run time, for example via an environment variable. Tracing will likely have to 
be done to a file. Tracing should be added to RABindings.c and the File pointer 
could be stored in ra_agenthandle_t. Contact Dave Smith.
Comment 1 Christine Knight CLA 2005-01-21 11:12:42 EST
not contained in 4.0, moving to 4.1 as P1
Comment 2 Sri Doddapaneni CLA 2005-03-30 14:26:03 EST
This is targeted for new agent controller.
Comment 3 Hoang M. nguyen CLA 2005-04-28 14:11:33 EDT
Here are some clarification on this request with Dave Smith:

- this tries to aid the debugging on the agent side 
(mainly named pipe but shared memory would be a nice addition).

- because the AC will support multiple instances on the same system,
  the environment variable may not work well. 
  The suggestion is to make it configurable in the AC configuration file:
     AGENT_COMM_TRACE = YES/NO
     AGENT_COMM_TRACE_FILE = trace.log

  In the future, if we need dynamic configuration, this could be converted
  in to an AC command at run time.

  The single log will contain traces for all agents (with proper agent id tags)

- The main communication activities that are need to be logged
  are in "RABindings.c" and "hcbnd.c"

Here is the summary of the effort:

- impact to the configuration reading and setting

- named pipe and shared memory operations will be traced

Sizing: 

- two weeks to write up the design, review and approve by the community
  (especially what type of and how much info should be traced,
   and the format of the trace records, probably using CBE)
   . The design will appy for any transport layer (e.g. socket is included)

- one week of coding and testing

Comment 4 Sri Doddapaneni CLA 2005-04-28 14:41:35 EDT
I expanded the scope to cover tracing for client, agent controller, and base 
agent layers. Changed the title to reflect the expanded scope.
Comment 5 Hoang M. nguyen CLA 2005-04-28 20:14:04 EDT
See this URL for latest sizing and design issues:
http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_79564.html
Comment 6 Paul Slauenwhite CLA 2005-05-31 11:32:18 EDT
*** Bug 97159 has been marked as a duplicate of this bug. ***
Comment 7 Paul Slauenwhite CLA 2005-05-31 11:32:49 EDT
This feature should also provide a configurable logging facility for Agent 
Controller and agents.

For increased serviceability of the new Agent Controller code and all C/++ and 
Java agents written for the new Agent Controller, provide a configurable 
logging facility with the following capabilities (analogous to JSR-047 or Java 
Logging):

-Level filtering for different uses (e.g. loggers).
-Configurable sinks (e.g. handlers) for different uses (e.g. loggers) that can 
be configured based on logging level.
-File and Logging Agent sinks (e.g. handlers).
-Configuration for file sinks (e.g. handlers) to limit the total amount of 
storage resource consumed by the log file files (e.g. rollover).
-Common Base Event support.
Comment 8 Ruth Lee CLA 2005-07-12 11:20:44 EDT
Changing to P1 as per the 4.1 official plan.
Comment 9 Guru Nagarajan CLA 2005-08-12 13:21:42 EDT
Reassigned to Andy. 
Comment 10 Paul Slauenwhite CLA 2005-09-04 16:14:47 EDT
From defect #80013:

The new org.eclipse.hyades.logging.native native Common Base Event 
implementation should be used to reinstrument the existing log message in the 
Data Collection Engine for 
increased PD capabilities (e.g. viewing, filtering, sorting, analysis, 
correlation).  This includes:

-Port the existing instrumented log messages (e.g. ra_logServiceMessage()) to 
log native Common Base Events including a situation and source component ID.

-Instrument new log messages for all types of situations:

-Start
-Stop
-Connect
-Configure
-Request
-Feature
-Dependency
-Create
-Destroy
-Report
-Available
-Other

See fix for defect https://bugs.eclipse.org/bugs/show_bug.cgi?id=79657 for an 
illustrative example of Common Base Event logging in C/++.
Comment 11 Andy Kaylor CLA 2005-09-19 12:24:52 EDT
The basic logging support is in place for the Agent Controller and agents.  I 
still need to look into the code and make sure the logging service is actually 
being called at the appropriate places.

A few other loose ends need to be tied up, such as logging from shared 
libraries, client logging, and filtering based on a configured log level.
Comment 12 Andy Kaylor CLA 2005-10-07 12:54:36 EDT
The logging framework has been put in place for the new Agent Controller.  I 
have opened new bugzilla reports to capture the remaining effort to round this 
out more fully.  These new items are: 111943, 111946 and 111947
Comment 13 Paul Slauenwhite CLA 2009-06-30 08:07:46 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.