Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 7846 - [Presentations] CLabel and CTabFolder should directly support system colours for gradients
Summary: [Presentations] CLabel and CTabFolder should directly support system colours ...
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: Other other
: P5 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 10963 24337 (view as bug list)
Depends on:
Blocks: 7794
  Show dependency tree
 
Reported: 2002-01-17 11:07 EST by Nick Edgar CLA
Modified: 2014-08-19 05:16 EDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-01-17 11:07:23 EST 
Build 20020115

When the titlebar system colous are changed, Eclipse titlebars do not update.
Likewise for the current view or editor tab.
You have to restart to get the new colours
See trigger bug 7794.

Currently we set the background gradient colours on the corresponding CLabels 
and CTabFolders using the system colours SWT.COLOR_TITLE_BACKGROUND, 
SWT.COLOR_TITLE_BACKGROUND_GRADIENT, and SWT.COLOR_WIDGET_BACKGROUND.
These system colors are cached in Eclipse UI (see code in 
WorkbenchColors.startUp).
Comment 1 Kevin Haaland CLA 2002-04-03 17:30:18 EST 

*** This bug has been marked as a duplicate of 7712 ***
Comment 2 Kevin Haaland CLA 2002-04-03 17:31:05 EST 
OOPS. Was searching for 7712
Comment 3 Mike Wilson CLA 2002-04-15 14:48:02 EDT 
*** Bug 10963 has been marked as a duplicate of this bug. ***
Comment 4 Veronika Irvine CLA 2002-05-27 16:21:36 EDT 
Requires new API.
Will revisit after R2.0.
Comment 5 Veronika Irvine CLA 2002-09-10 10:24:43 EDT 
Post 2.0. Re-opening bug reports for review.
Comment 6 Billy Biggs CLA 2004-05-07 12:23:39 EDT 
On Linux-Gtk+, the ::style-set signal is emitted when the system colours are
changed:

http://developer.gnome.org/doc/API/2.0/gtk/GtkWidget.html#GtkWidget-style-set
http://mail.gnome.org/archives/gtk-devel-list/2002-October/msg00115.html

This could be used to implement an event which indicates that the system colour
constants in SWT have been updated.
Comment 7 Veronika Irvine CLA 2004-05-07 14:46:00 EDT 
This info is good to know.  However, it is not actually relevant to this bug 
report.  Maybe it should be added to bug 37457 or a new bug should be entered 
about GTK not responding to system colour changes.

This bug is not really about knowing when the system colours change.  This bug 
is about the fact that the CLabel and CTabFolder API takes Color as arguments 
and not SWT.COLOR_* constants.  Even if CTabFolder knew that the system 
colours had changed, it would not know that the Color object it was given was 
derived from a system colour and not just some other RGB values picked by the 
application designer.
Comment 8 Billy Biggs CLA 2004-05-07 15:29:43 EDT 
Thanks, I opened bug 61445.
Comment 9 Veronika Irvine CLA 2004-05-13 17:17:49 EDT 
*** Bug 24337 has been marked as a duplicate of this bug. ***
Comment 10 Steve Northover CLA 2007-05-18 08:07:17 EDT 
This could now be fixed in UI by (carefully) using a SWT.Settings listener on the display to reset the system colors.  I don't recomend doing this so late in 3.3.  When/if this bug is fixed, I'd like to review the code.
Comment 11 Kevin McGuire CLA 2007-05-28 11:56:11 EDT 
Yes this would be a fairly significant change, since it needs to rippled through the workbench themes, etc., to be propagated to the CTabFolder.
Comment 12 Kevin McGuire CLA 2009-04-23 14:13:17 EDT 
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 13 Lars Vogel CLA 2014-08-19 05:16:38 EDT 
Possible these days with CSS. While this was fixed, I mark it as worksforme as I don't think it is worth hunting down the commit id.