Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 77652 - [Preferences] PreferenceDialog.okPressed() implementation change (regression)
Summary: [Preferences] PreferenceDialog.okPressed() implementation change (regression)
Status: RESOLVED DUPLICATE of bug 75988
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-03 10:40 EST by Eckart Langhuth CLA
Modified: 2004-11-08 08:34 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eckart Langhuth CLA 2004-11-03 10:40:40 EST
Hi all,
in version 2.x an IPreferencePage was able to veto against closing the Dialog 
by returning false from page.performOk(). (To prevent problems when facing an 
inconsistent state)
In 3.0 implementation the loop over the pages is contained in a 
try/catch/finally. 
The finally block contains invocation of close().
Within the loop there is the statement: if (!page.performOk())return;
This means whenever a page tries to veto against closing the Dialog all pending 
pages will be closed without a call to performOK() and the Dialog is closed.

Best regards 
Eckart
Comment 1 Tod Creasey CLA 2004-11-08 08:34:29 EST

*** This bug has been marked as a duplicate of 75988 ***