Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 76853 - Save participant needs to call ISaveContext.needDelta()
Summary: Save participant needs to call ISaveContext.needDelta()
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M5   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-22 14:48 EDT by Michael Valenta CLA
Modified: 2005-01-18 09:40 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2004-10-22 14:48:45 EDT 
I'm trying to understand how the ISaveParticipant mechanism is used by the CVS 
integration. ISaveContext.needDelta() method is never called by the CVS 
plugins but there is an attempt to process saved resource deltas in 
FileModificationManager.registerSaveParticipant(). Documentation for 
ISavedState.processResourceChangeEvents() explicitly states that no 
notifications will be available for past events if the method in subject 
wasn't previously called. If I'm interpreting documentation correctly there 
may be an obscure bug in the CVS integration which never surfaced because CVS 
plugins are likely to be initialized on startup because decorators are 
typically enabled.
Comment 1 Michael Valenta CLA 2004-10-22 14:49:24 EDT 
The above was posted on the team mailing list and is correct. We should 
investigate further.
Comment 2 Michael Valenta CLA 2005-01-18 09:40:25 EST 
It turns out that ISaveParticipant doesn't give us the proper behavior and I 
have come up with another solution. I have removed the code associated with 
this bug.