Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 74612 - Step filtering pref page should allow you to enable step filters
Summary: Step filtering pref page should allow you to enable step filters
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 75777 113381 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-09-22 12:52 EDT by Darin Swanson CLA
Modified: 2006-03-14 15:14 EST (History)
2 users (show)

See Also:

Attachments
Adds UseStepFilters button to JavaStepFilterPreferencePage (4.41 KB, patch)
2005-12-21 13:01 EST, Gary Barbon CLA 		no flags Details | Diff
patch (40.32 KB, patch)
2006-03-07 16:52 EST, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2004-09-22 12:52:52 EDT 
The step filtering pref page references that filters are only enabled when the 
step filters toggle is activated. 

The pref page should allow you to enable/disable the step filters as well as 
the toggle action in the debug view tool bar.
Comment 1 Darin Wright CLA 2004-10-07 10:47:22 EDT 
*** Bug 75777 has been marked as a duplicate of this bug. ***
Comment 2 Darin Wright CLA 2005-04-27 23:52:58 EDT 
Deferred. The preference in the Debug UI is not public, so the Java Debug UI 
cannot legally reference it.
Comment 3 Darin Wright CLA 2005-10-21 14:19:20 EDT 
*** Bug 113381 has been marked as a duplicate of this bug. ***
Comment 4 Randy Hudson CLA 2005-10-21 14:23:43 EDT 
The "Enable All" button is misleading on the preference page. The Controls on 
the preference page should be disabled whenever the global step filtering is 
disbabled.
Comment 5 Darin Wright CLA 2005-12-20 14:47:12 EST 
The "enable/disable all" buttons should be re-lablelled to "Select All/Deselect All". Should add a check box at the top of the page to enable step filters, that toggles the IInternalDebugUIConstants.PREF_USE_STEP_FILTERS preference. This pref should be moved to IDebugUIConstants, so other plug-ins can access it as API.
Comment 6 Randy Hudson CLA 2005-12-20 15:14:34 EST 
Do you agree the UI should be disabled? This would be consistent with the UI for setting the editor reuse limit, and it just makes sense and points out the new change.
Comment 7 Gary Barbon CLA 2005-12-21 13:01:57 EST 
Created attachment 32091 [details]
Adds UseStepFilters button to JavaStepFilterPreferencePage

Addresses issues in Comment #5, as well as disabled the interactive widgets of the preference page when the option is disabled.
Comment 8 Gary Barbon CLA 2005-12-21 13:02:34 EST 
assigning to Darin for review.
Comment 9 Michael Rennie CLA 2006-03-07 16:52:44 EST 
Created attachment 35864 [details]
patch

updated patch, refined pref page
Comment 10 Michael Rennie CLA 2006-03-07 16:53:50 EST 
committed the debug.ui stuff, here is the jdt.ui stuff

please verify Darin W
Comment 11 Darin Wright CLA 2006-03-14 15:13:55 EST 
Applied patch.
Comment 12 Darin Wright CLA 2006-03-14 15:14:09 EST 
Verified.