Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 72151 - [find/replace] combobox needs to remember more items
Summary: [find/replace] combobox needs to remember more items
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P4 enhancement with 5 votes (vote)
Target Milestone: 4.7 M4   Edit
Assignee: Björn Michael CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-18 04:25 EDT by Noel Grandin CLA
Modified: 2016-11-28 13:19 EST (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
patch to do this for the workspace search dialog (1.05 KB, patch)
2005-04-06 09:37 EDT, Noel Grandin CLA 		no flags Details | Diff
patch to do this for the text editor search dialog (889 bytes, patch)
2005-04-06 09:38 EDT, Noel Grandin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noel Grandin CLA 2004-08-18 04:25:14 EDT 
I often search for 10-20 different things in various files over the course of 
an hour. 
But the dropdown combobox in the find/replace dialog only appears to remember 
the last 7 search terms.
Ideally, the computers memory should exceed mine :-)

Request: make it remember 30 items - that should exceed the list of things that 
I can remember searching for :-)
Comment 1 Dani Megert CLA 2004-08-18 04:35:56 EDT 
It's 8 not 7 ;-)
Comment 2 Noel Grandin CLA 2005-04-06 09:37:37 EDT 
Created attachment 19594 [details]
patch to do this for the workspace search dialog
Comment 3 Noel Grandin CLA 2005-04-06 09:38:09 EDT 
Created attachment 19595 [details]
patch to do this for the text editor search dialog
Comment 4 Dani Megert CLA 2005-04-06 09:48:59 EDT 
Noel, the first patch needs to be submitted for Platform Search.
Comment 5 Noel Grandin CLA 2005-04-06 10:09:01 EDT 
Sorry, I'm not understanding you - do you mean the patch is against the wrong
plugin, or the patch needs to be submitted in a different bug, or... ????

For reference, the first patch is in the org.eclipse.search plugin, and the
second patch is in the org.eclipse.ui.workbench.texteditor plugin.

Both patches are vs. current HEAD of CVS.
Comment 6 Dani Megert CLA 2005-04-06 10:30:33 EDT 
org.eclipse.search plug-in belongs to Platform Search component and hence you
have to file a bug there and attach the patch from comment 2.
Comment 7 Noel Grandin CLA 2005-04-07 03:13:14 EDT 
Filed bug <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=90569">90569</a>
for the platform search patch.
Comment 8 Eclipse Genie CLA 2016-09-25 14:58:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/81871
Comment 10 Dani Megert CLA 2016-11-28 11:21:13 EST 
(In reply to Eclipse Genie from comment #9)
> Gerrit change https://git.eclipse.org/r/81871 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=6ac9ef9309a19dca183c39b074ec5f5f92357460
> 

Thanks Björn!
Comment 11 Noel Grandin CLA 2016-11-28 13:19:45 EST 
thank you very much!