Description Jan Schulz 2004-08-09 08:09:53 EDT

Hello,

I'm currently packaging eclipse for debian and I run into problems with your 
makefile for motif and gtk. It requires, that it is patched before I could use 
it on my system. To make as less changes as possible, I had to do two patches to 
the make of gtk:

+MOZILLA_INCLUDES=$(MOZILLA_HOME)/includes

and then using this instead of the old one: 
-       -I$(MOZILLA_HOME)/include \
+       -I$(MOZILLA_INCLUDES) \
(and so on...)

The other chnage was defining one more libdir
                -I$(JAVA_HOME)/include \
+               -I$(JAVA_HOME)/include/linux \

Thsi is required for all non IBM JDKs. It would be even better if that was also 
overwritebale completly, like replacing it with 
JAVA_HOME_INCLUDES := -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux
and using this. This way I could set this variables in the makefile call and be 
happy.

BTW: here is the call, which I need on my debian system *after* patching:

# build gtk jni files
build/libswt3.0-gtk2-jni:: debian/stamp-copy-all-together-gtk
        cd plugins/org.eclipse.swt/gtk_bin/library/ && \
        make -f make_gtk.mak make_swt make_atk make_gnome make_mozilla \
        MOZILLA_INCLUDES=/usr/include/mozilla \
        JAVA_HOME=$(JAVA_HOME) \
        MOZILLA_HOME=/usr/lib/mozilla \
        MOZILLALIBS="-L/usr/lib/mozilla -lgtkembedmoz -lxpcom"
        cp plugins/org.eclipse.swt/gtk_bin/library/*so plugins/org.eclipse.swt/
Eclipse\ SWT\ PI/gtk/library/

The MOZILLALIBS overwrite is nessesary with latest mozilla and firebird packages 
I have on my system.

I attach the patches which I used. There are similar things done in the motif 
makefile.

As a sidenote: IMO it would be better to don't set the default in a machine 
dependend way, but use resonable defaults and use a build.sh file to set this in 
the makefile call.

Nice greetings, Jan