Bug 70321 - [Preferences] TVT 3.0: Project reference properties page clipped in Italian language pack
Summary: [Preferences] TVT 3.0: Project reference properties page clipped in Italian l...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Karice McIntyre CLA Friend
QA Contact:
URL:
Whiteboard:
Keywords: nl
Depends on:
Blocks:
 
Reported: 2004-07-19 08:26 EDT by Dirk Baeumer CLA Friend
Modified: 2005-09-26 16:50 EDT (History)
4 users (show)

See Also:


Attachments
Screen shot (79.28 KB, image/gif)
2004-07-19 08:27 EDT, Dirk Baeumer CLA Friend
no flags Details
ProjectReferencePage.java patch (1.05 KB, patch)
2005-08-18 11:42 EDT, Karice McIntyre CLA Friend
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA Friend 2004-07-19 08:26:47 EDT
See bug 70111 where the original problem got reported.
Comment 1 Dirk Baeumer CLA Friend 2004-07-19 08:27:45 EDT
Created attachment 13408 [details]
Screen shot
Comment 2 Tod Creasey CLA Friend 2004-07-19 08:43:29 EDT
This is likely the platform wrapping algorithm.
Comment 3 David W Hare CLA Friend 2004-07-26 10:38:54 EDT
any status on this?
Comment 4 Tod Creasey CLA Friend 2005-08-10 10:51:21 EDT
Susan please investigate - this is a potential 3.1.1 candidate
Comment 5 Susan McCourt CLA Friend 2005-08-16 15:14:21 EDT
I want to make sure I understand the problem in the screen shot.

Is the problem 
(A) that the second sentence was forced to a new line?  That is what the 
annotation in the screen shot appears to be saying.
    or
(B) there is missing (clipped) text.  That is what this bug title is 
suggesting, but since I don't understand Italian I can't tell.  If the text is 
clipped, where is it clipped - on the right hand side of the first line?  And 
if so, was the dialog initially wrong or was it resized to cause the clipping?

I checked the source code and English translation.  
For (A) 
There is a new line character (\n) embedded between the sentences.  If this 
was carried forward into the Italian translation, then we would see the forced 
line.  I could not tell by the tester's annotation whether he/she checked for 
a new line character or a tag.  Where can one check the translated 
messages.properties files?  The message name is ProjectReferencesPage_label

For (B)
The dialog will size the description label as wide as needs to be and wrap the 
rest.  Once displayed, if the dialog is then resized smaller, the text could 
clip.  

Comment 6 Susan McCourt CLA Friend 2005-08-16 15:17:24 EDT
(B) could likely be fixed by tweaking the layout if this is the problem, but 
it would help to know more detail about the clipping (what the text should say 
in addition to what is showing).
Comment 7 Karice McIntyre CLA Friend 2005-08-18 11:42:39 EDT
Created attachment 26237 [details]
ProjectReferencePage.java patch

Needed to set layout on description label after overriding
createDescriptionLabel() method from PreferencePage.
Comment 8 Karice McIntyre CLA Friend 2005-08-18 13:01:21 EDT
Tested on Linux.  The label now extends to the edge of the composite.  

There will still be cases where the dialog wraps the text as in the original 
problem - e.g. when the previously selected page(s) does not make the dialog 
wider.  But it will work better than before.
Comment 9 Tod Creasey CLA Friend 2005-08-19 11:36:14 EDT
Released to HEAD and 3.1.1 for build >20050819
Comment 10 Karice McIntyre CLA Friend 2005-09-26 16:50:05 EDT
Verified in 3.1.1 RC2 Italian (using 0923 catalogs)