Community
Participate
Working Groups
3.0 RC2 Test Pass Switch Workspace... should not switch if current is selected or at least ask whether this is really desired.
The current behaviour is the design intent. Allowing the workbench to restart on the same workspace is convenient in cases such as changing the Current presentation preference. The preference change is not completed until the workbench has been restarted.
what about asking whether this is really desired?
Since there is no harm in reopening the same workspace, I'm not sure there's value in the extra confirmation. On the other hand adding an extra click is sure to annoy users.
"Restart workbench" is semantically different to "Switch workspace.. [to the current workspace]", plus if you are keeping the same workspace then are you really switching? I can see the need for an ability to restart the workbench, especially after a user declines an option to have it done automatically for them or being otherwise prompted, but I don't think the right place for this is in overloading the functionality of switch workspace. On the business of extra clicks, I would rather be warned that the target workspace is the current one than have to wait for Eclipse to restart (which can take some time and loses some minor settings such as editor cursor locations) and realising that I didn't select the right workspace, forcing me to repeat the operation, selecting the correct workspace. (Of course, the cursor setting comment is of little consequence if I'm only going to switch out of the workspace).