Community
Participate
Working Groups
RC1 Despite these two classes being pretty much identical they share almost no code. TaskPropertiesDialog should be a subclass a DialogMarkerProperties. As this is an API change post 3.0
Not for 3.0
Reopening now that 3.0 has shipped
marking for 3.3. This came up while integrating marker undo...I implemented the undo in DialogMarkerProperties and then realized there was a duplicate API class that JDT and others were using. This will get cleaned up as part of the undo marker work. Tod, is there any history I should know about..ie, why there is an internal dialog and an API dialog doing the same thing?
this will go in for M2 as part of marker operation undo support.
Fixed in HEAD, >20060822. The DialogMarkerProperties hierarchy was reorganized so that all marker dialogs inherit this implementation rather than copying/changing the implementation. This means that some public classes, such as TaskPropertiesDialog and BookmarkPropertiesDialog, are inheriting API implementations from a private superclass. Per discussions with Boris, in these cases, the API methods are overridden in the public subclasses, calling the super implementations. The internal superclasses are documented to emphasize that public API classes are dependent on their implementation, and the specific methods in question are also specially documented.
verified through source code inspection, I20060919-0010
