Community
Participate
Working Groups
markerHelp does not seem to be working - probable regression I'm trying out my own markerHelp implementation and not getting anywhere, so I dropped back to try and see if the example in the readmetool was working; it is not. I can take a 2.1.1 system and just add the examples, create a readme file, use the add> context menu and add the 1234 marker. Select the marker in tasks view and press F1 - I get a marker help hover. Same process on RC1/0529 code fails. I get the workbench popup help with hyperlinks for Workbench, Perspectives, and Workbench management.
We should probably investigate this regression for 3.0
Status request.
could you attach an example that does/does not work in 2.1 and 3.0
No need. Use the org.eclipse.ui.examples.readmetool in the examples zip. Works in 2.1, does not in 3.0. Test path once installed (unzip on top of a base install) -Create simple project. -Use wizard to create readme file in project (in examples cat) -Swipe text in readme file editor - use context menu Add > marker example 6 -Marker in tasks view (you may have to adjust filters to let the readme marker type be visible). -Select marker in view. Two tests (Quick fix is not working either) 1> Context menu - quick fix - should open dialog with Add Sentence proposals 2> F1 while marker with 1234, code=7 red... is selected should open a popup with this text content: Readme marker example 6 Help id = 1234, level = 7, department = infra, code = red, language = english Above paste from the 2.1.2 test I just ran. I've recreated same myself - but the readme example is more convenient and fails just the same.
stefan could you investigate whether this is this a regression?
Created attachment 12685 [details] Fixes marker help This is indeed a regression. This patch fixes the F1 help for markers. Note: I believe that the quickfix thing is an intentional behavior: you can fix a problem, but not a task or bookmark. Quickfix still works for the problems view. Please file another bug for the missing quickfix if you know of a good use case for it.
Quick fix is fine. I was in 2.1 mode in my head looking in tasks view. I'll see if I can test the patch.
Patch file is bad - but got it to work. (Patch content in there twice?). Tests fine for me on top of RC3 using readme example.
Ironically, the repeated patch thing is a bugzilla bug. Whenever you attach a patch to a bugzilla PR and select the "patch" button, it copies everything in the file twice. :-)
needs to be reviewed by Arch. Group. marking as RC4
Verified patch. +1
Released and verified patch with SX. Released for build 20040623-1600
*** Bug 68441 has been marked as a duplicate of this bug. ***
Verified by Debbie and Stefan on I20040624 (0800).
