Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 65578 - Binary projects are being validated by PDE
Summary: Binary projects are being validated by PDE
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-03 13:05 EDT by Wassim Melhem CLA
Modified: 2004-06-09 12:36 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2004-06-03 13:05:41 EDT 
Build: RC1

Import org.eclipse.jdt.debug.ui as binary.
You will see that its plugin.xml has warnings.
Since manifest files must not be validated in binary projects, and since I 
recall seeing commments in our code that say: "if it's binary, then skip 
validation" or words to that effect, this might simply imply that the check if 
a project is binary is returning false when it's actually true.
Comment 1 Dejan Glozic CLA 2004-06-07 17:39:56 EDT 
This only happens if the project is imported as binary without linking. The 
test for binary plug-in project is flawed in that it expects to find 
BinaryRepositoryProvider. We only use this provider for linked binary projects:

				String binary = project.getPersistentProperty
(PDECore.EXTERNAL_PROJECT_PROPERTY);
				if (binary != null) {
					RepositoryProvider provider = 
RepositoryProvider.getProvider(project);
					return provider instanceof 
BinaryRepositoryProvider;
				}

The fix is to allow the provider to be null (local binary project).
Comment 2 Rafael Chaves CLA 2004-06-09 11:14:33 EDT 
Can this be contributing to bug 66228 as well? I have the whole SDK (except for
our own plugins) as binary projects. Is this fixed for i200406082000?
Comment 3 Wassim Melhem CLA 2004-06-09 12:36:19 EDT 
This bug was certainly contributing to the overall problem, but has been fixed 
in builds from yesterday.

There are other remaining issues with the builder.