Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 65448 - Code folding expand/collapse icons should be changed
Summary: Code folding expand/collapse icons should be changed
Status: RESOLVED DUPLICATE of bug 61725
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-02 17:24 EDT by Ed Burnette CLA
Modified: 2004-06-13 14:23 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Burnette CLA 2004-06-02 17:24:55 EDT
In 3.0RC1 on Windows the code folding icons are as follows: a filled in 
triangle pointing right for folded text, and an empty triangle pointing down 
for expanded text. These should be changed to standard plus/minus icons for 
the following reasons:

- The triangles have a Java Swing-ish look about them that doesn't fit with 
the rest of the native SWT interface.
- Triangles are inconsistent with the plus/minus icons used in the Package 
Explorer and Navigator and several other views.
- They're also also different from other products developers are familiar with 
such as Visual Studio and Netbeans 3.6, including SAS products (Display 
Manager, webAf Studio, and Enterprise Guide). All these products use plus and 
minus icons for code folding on Windows.
- The filled and unfilled triangles don't look as good (admittedly this is 
subjective).
- They can get confused with the Java inheritance icon which is an empty 
triangle of the same size and shape (except it's a little further to the left 
and pointing up).
- They have less visual surface area than the standard plus/minus icons so 
they are harder to target with the mouse cursor.
- They give no hint about the keyboard shortcut for expand/collapse (Ctrl-
Keypad_Plus and Ctrl-Keypad_Minus).

It would be best to use native expand/collapse icons, i.e., the same ones that 
the tree and table tree widgets use, if that's possible. But always using the 
standard plus and minus icons would be the second best (and perhaps simpler) 
option. Either would be better than the triangles.

Please forward to the UI design team for consideration if needed.
Comment 1 Billy Biggs CLA 2004-06-02 17:34:04 EDT
FWIW, the plus/minus icons used in the package explorer are platform dependent.
 With most Gtk+ themes they are unfilled triangles (and happen to match the code
folding triangles).
Comment 2 Davor Cubranic CLA 2004-06-13 13:46:47 EDT
I think this bug is a duplicate of bug 61725.
Comment 3 Ed Burnette CLA 2004-06-13 14:23:48 EDT

*** This bug has been marked as a duplicate of 61725 ***