Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 65160 - [Progress] BlockedJobsDialog should have a non modal default
Summary: [Progress] BlockedJobsDialog should have a non modal default
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-01 16:31 EDT by Tod Creasey CLA
Modified: 2004-06-07 08:22 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2004-06-01 16:31:50 EDT 
RC1

As the BlockedJobsDialog only opens when the modal shell is done blocking if 
the shell is not specified it should use getNonModalShell not getDefaultShell

Index: BlockedJobsDialog.java
===================================================================
RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse 
UI/org/eclipse/ui/internal/progress/BlockedJobsDialog.java,v
retrieving revision 1.26
diff -u -r1.26 BlockedJobsDialog.java
--- BlockedJobsDialog.java	27 May 2004 14:54:04 -0000	1.26
+++ BlockedJobsDialog.java	1 Jun 2004 20:29:20 -0000
@@ -232,7 +232,7 @@
 	private BlockedJobsDialog(Shell parentShell, IProgressMonitor blocking,
 			IStatus blockingStatus) {
 		super(parentShell == null
-				? ProgressManagerUtil.getDefaultParent()
+				? ProgressManagerUtil.getNonModalShell()
 				: parentShell);
 		blockingMonitor = blocking;
 		if (blockingStatus instanceof IJobStatus)
Comment 1 Tod Creasey CLA 2004-06-03 10:18:34 EDT 
Fixed in build >20040603
Comment 2 Tod Creasey CLA 2004-06-07 08:22:39 EDT 
Verified in 20040604