Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 65134 - [Dialogs] PropertyDialog closes when the user presses Ok even if an error happened.
Summary: [Dialogs] PropertyDialog closes when the user presses Ok even if an error hap...
Status: RESOLVED DUPLICATE of bug 75988
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-01 15:42 EDT by Jay Wootton CLA
Modified: 2005-01-05 13:18 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Wootton CLA 2004-06-01 15:42:56 EDT 
I have implemented a property page and if I encounter an error while trying to 
save my data I return false from performOk().

In the okPressed() method in PreferenceDialog.java, performOk() is called for 
each page.  If a page returns false from performOk()then the calling of 
performOk() stops and the dialog is closed.

I believe that the dialog should not close if a page returns false from 
performOk().  This can result in the loss of data.
Comment 1 Tod Creasey CLA 2004-06-28 11:35:30 EDT 
This is actually a bug - any false should cancel this.
Comment 2 Tod Creasey CLA 2005-01-05 13:18:47 EST 

*** This bug has been marked as a duplicate of 75988 ***