Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 65017 - [Workspace] Workspace launcher dialog default button is browse
Summary: [Workspace] Workspace launcher dialog default button is browse
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.0   Edit
Hardware: Sun Solaris
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-01 11:46 EDT by Tod Creasey CLA
Modified: 2007-10-30 02:35 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2004-06-01 11:46:17 EDT
RC1

When the workspace starts up the default button for the workspace dialog is the
Browse button which means you cannot just hit OK to start.

This is OK on Windows so I suspect this is a problem on Solaris when the default
button is not set
Comment 1 Andrew Eidsness CLA 2004-08-04 12:37:14 EDT
Also, pressing tab should eventually select Cancel; this works on xp but not on 
solaris.

As far as I can tell the code is correct.  This dialog is actually derived from 
the jface jface Dialog class which is where the OK and Cancel buttons are added 
with:

protected void createButtonsForButtonBar(Composite parent) {
	// create OK and Cancel buttons by default
	createButton(parent, IDialogConstants.OK_ID, IDialogConstants.OK_LABEL, 
true);
	createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.
CANCEL_LABEL, false);
}

There is no place in the ChooseWorkspaceDialog where a different button is 
selected as the default.

The problems that I see are:

    1. OK should be selected by default
    2. Cancel should be in the tab order

Forwarding to SWT for comment.
Comment 2 Steve Northover CLA 2007-10-30 02:35:42 EDT
Solaris Motif is no longer a supported Eclipse platform.