Bug 65000 - [Eclipse Forms] Trees/tables in forms missing borders on Motif
[Eclipse Forms] Trees/tables in forms missing borders on Motif
Status: RESOLVED FIXED
Product: Platform
Classification: Eclipse
Component: UI
3.0
PC Linux
: P2 normal (vote)
: 3.0 RC3
Assigned To: Dejan Glozic CLA Friend
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2004-06-01 11:16 EDT by Michael Van Meekeren CLA Friend
Modified: 2004-06-16 11:28 EDT (History)
0 users

See Also:


Attachments
dependancies page (63.78 KB, image/png)
2004-06-01 11:16 EDT, Michael Van Meekeren CLA Friend
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA Friend 2004-06-01 11:16:27 EDT
The list items in the manifest editor on MOTIF seem to be without borders.

See attachment
Comment 1 Michael Van Meekeren CLA Friend 2004-06-01 11:16:52 EDT
Created attachment 11372 [details]
dependancies page
Comment 2 Wassim Melhem CLA Friend 2004-06-15 14:03:33 EDT
The culprit is the code that computes flat border RGB:

if (isWhiteBackground())
   border = getColor(BORDER);
else
   border = display.getSystemColor(SWT.COLOR_WIDGET_BACKGROUND);

This code works well when form background is lighter than widget background.
However, on Motif form and widget backgrounds are the same, so borders are
painted but cannot be seen.

The proposed fix is to test for this and use SWT.COLOR_WIDGET_DARK_SHADOW in
case widget and form backgrounds are the same. I tested this on Motif and it
looks very good (dark gray border on gray background). This will also hold when
colors are changed i.e. border will always be of the same shade as the
background, just darker.

Michael, I propose this for RC3 - please vote if you agree.
Comment 3 Wassim Melhem CLA Friend 2004-06-15 14:04:07 EDT
Raising priority because this affects ALL trees and tables in all forms on Motif.
Comment 4 Dejan Glozic CLA Friend 2004-06-15 14:15:40 EDT
The last two comments are really by me - I made them from a Motif machine 
previously used by Wassim :-).
Comment 5 Dejan Glozic CLA Friend 2004-06-16 11:28:33 EDT
Fixed and released.