Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 64182 - Loading org.eclipse.jdt.ui.tests from HEAD results in lot of warnings in its plugin.xml
Summary: Loading org.eclipse.jdt.ui.tests from HEAD results in lot of warnings in its ...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC3   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 60508 65976 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-05-26 13:52 EDT by Olivier Thomann CLA
Modified: 2004-06-20 21:23 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2004-05-26 13:52:58 EDT
Using 0526_0800, loading the org.eclipse.jdt.ui.tests project from CVS results
in lot of warnings reported against its plugin.xml file. They seem to be related
to missing schema files.
Severity	Description	Resource	In Folder	Location	Creation Time
1	Element 'enablement' is not legal as a child of element
'quickFixProcessor'.	plugin.xml	org.eclipse.jdt.ui.tests	line 95	21 mai 2004
19:10:10
etc.

The schemas are available in the source location, not in the binary plugins
location.
Comment 1 Wassim Melhem CLA 2004-05-26 14:18:13 EDT
>The schemas are available in the source location, not in the binary plugins
>location.
what do you mean by that?  We retrieve the schemas from the source plug-ins 
that come with the sdk.  are you claiming otherwise?
Comment 2 Olivier Thomann CLA 2004-05-26 14:41:29 EDT
Then why do I have so many warnings?
Comment 3 Olivier Thomann CLA 2004-05-26 14:51:08 EDT
I get warnings saying that the element 'enablement' is not legal as a child of
element 'renameParticipant'.
But if I look at the schema for the renameParticipant I can find:

   <element name="renameParticipant">
      <complexType>
         <all>
            <element ref="enablement"/>
         </all>
...

And at the beginning of the file renameParticipants.exsd I can find:
   <include
schemaLocation="schema://org.eclipse.core.expressions/schema/expressionLanguage.exsd"/>

where the enablement is defined. Is the problem due to the schema link format?
Comment 4 Olivier Thomann CLA 2004-05-26 14:57:44 EDT
When you have a link like this:
<include
schemaLocation="schema://org.eclipse.core.expressions/schema/expressionLanguage.exsd"/>,
where do you look for the schema? Inside the source location of
org.eclipse.core.expressions? Or directly inside the binary plugin location of
org.eclipse.core.expressions?
Comment 5 Dejan Glozic CLA 2004-05-26 15:34:19 EDT
The URL format above is processed by extracting 'org.eclipse.core.expressions' 
as schema id and passing it to the schema manager for return a matching schema 
object. The manager in turn uses the same algorithm as for locating any other 
schema given the ID. I think that the one in the workspace will win over 
external ones.
Comment 6 Dejan Glozic CLA 2004-05-26 15:35:11 EDT
Having said that, I know there are issues with schemas because they are 
located in source distribution and that complicates the search.
Comment 7 Olivier Thomann CLA 2004-05-26 15:38:00 EDT
It isn't in my workspace.
In my workspace I simply have jdt.core + all jdt.core tests + jdt.ui tests +
jdt.ui.refactoring tests.
So I don't have jdt.ui or ltk.core.refactoring.

Did you reproduce this issue?
Comment 8 Wassim Melhem CLA 2004-05-26 21:44:11 EDT
I was able to reproduce the warnings.  
One of the warnings was valid.  There is <quickFixProcessor> as a child of a 
quickAssistProcessor extension, which is false.

As for the other ones, I don't think the problem has anything to do with what 
is in/outside the workspace.  I think it's our handling of included schemas 
that is buggy.
Comment 9 Dejan Glozic CLA 2004-05-27 09:59:36 EDT
Can you elaborate that claim a bit?
Comment 10 Wassim Melhem CLA 2004-06-07 16:34:24 EDT
For instance, look at the warnings that we have in the plugin.xml for 
org.eclispe.pde.ui.
Comment 11 Wassim Melhem CLA 2004-06-08 05:21:52 EDT
*** Bug 65976 has been marked as a duplicate of this bug. ***
Comment 12 Dejan Glozic CLA 2004-06-15 18:13:13 EDT
We correctly find the external plug-in using the schema:// protocol however 
the schema is not there. We need to consult source location manager to check 
the source location of the plug-in in question when looking for schema.
Comment 13 Dejan Glozic CLA 2004-06-16 11:10:27 EDT
Fixed and released.
Comment 14 Cherie Wong CLA 2004-06-17 20:00:30 EDT
Verified in I20040617-0800.
Comment 15 Wassim Melhem CLA 2004-06-20 21:23:20 EDT
*** Bug 60508 has been marked as a duplicate of this bug. ***