Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 62323 - Editor leak by PopupInspectAction
Summary: Editor leak by PopupInspectAction
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-14 13:56 EDT by Christof Marti CLA
Modified: 2004-05-20 20:35 EDT (History)
1 user (show)

See Also:

Attachments
Paths from GC roots (167.21 KB, text/plain)
2004-05-14 13:58 EDT, Christof Marti CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Marti CLA 2004-05-14 13:56:35 EDT 
Attachment with paths from GC roots follows shortly.
Comment 1 Christof Marti CLA 2004-05-14 13:58:01 EDT 
Created attachment 10656 [details]
Paths from GC roots

Paths from GC roots over PopupInspectAction to CompilationUnitEditor after
closing all editors.
Comment 2 Kevin Barnes CLA 2004-05-14 16:30:28 EDT 
fixes to 
PopupDisplayAction - set viewer to null when done
PopupInspectAction - set viewer to null, removed unnecessary asyncExec()
Comment 3 Kevin Barnes CLA 2004-05-14 16:31:01 EDT 
DarinS, please verify
Comment 4 Christof Marti CLA 2004-05-18 03:57:35 EDT 
I found the same leak in I200405171219 with the ZRH plugin-export from
20040518_0827:

GC Roots -> Object CompilationUnitEditor #0127d029: Reverse Paths

  |
  +---org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor (#0127d029)
    |
    +---fTargetPart of
org.eclipse.jdt.internal.debug.ui.actions.PopupInspectAction (#019b11a8)
      |
      +---delegate of org.eclipse.ui.internal.WWinPluginAction (#0119e583)
        |
        +---[38]  of java.lang.Object[173] (#0024eca2)
          |
          +---elementData of java.util.ArrayList (#0024f326)
            |
            +---staticActionList of org.eclipse.ui.internal.WWinPluginAction
(#00b1b8e7)


--------------------------------------------------------------------------------

GC Roots -> Object CompilationUnitEditor #0127d029: Direct Paths

  |
  +---org.eclipse.ui.internal.WWinPluginAction (#00b1b8e7)
    |
    +---staticActionList java.util.ArrayList (#0024f326)
      |
      +---elementData java.lang.Object[173] (#0024eca2)
        |
        +---[38]  org.eclipse.ui.internal.WWinPluginAction (#0119e583)
          |
          +---delegate
org.eclipse.jdt.internal.debug.ui.actions.PopupInspectAction (#019b11a8)
            |
            +---fTargetPart
org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor (#0127d029)

Reopening.
Comment 5 Kevin Barnes CLA 2004-05-18 11:27:20 EDT 
class was missing call to evaluationCleanup().
fixed in PopupInspectAction.
Comment 6 Kevin Barnes CLA 2004-05-18 11:27:44 EDT 
DarinS, please verify
Comment 7 Darin Swanson CLA 2004-05-20 20:35:44 EDT 
Verified.