Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 579367 - Refactor->Rename keys (Shift-Alt-R) do not work
Summary: Refactor->Rename keys (Shift-Alt-R) do not work
Status: CLOSED DUPLICATE of bug 579168
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.23   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-22 09:52 EDT by Tad Marko CLA
Modified: 2022-03-22 12:24 EDT (History)
4 users (show)

See Also:


Attachments
The list of software installed on my Eclipse STS based on Eclipse 4.23 (161.36 KB, image/png)
2022-03-22 10:42 EDT, Hrvoje Lončar CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tad Marko CLA 2022-03-22 09:52:53 EDT
Shift-Alt-R no longer works when editing Java code.

I verified that the key setting is correct (Preferences -> General -> Keys).

I tried setting it to a different custom key, it does not work with the new key.

I tried setting it to Shift-Alt-R as a custom key sequence, it does not work.

I tried setting it back to the default with "Restore Command", which did restore it to the Shift-Alt-R default, but it still does not work.
Comment 1 Wim Jongman CLA 2022-03-22 10:24:23 EDT
It works fine for me.

What additional plugins do you have installed? (pydev, spring, etc..)
Comment 2 Hrvoje Lončar CLA 2022-03-22 10:42:49 EDT
Created attachment 288265 [details]
The list of software installed on my Eclipse STS based on Eclipse 4.23

I'm giving this screenshot just to help others to identify plugins that might be the cause.
Comment 3 Wim Jongman CLA 2022-03-22 10:58:46 EDT
Hrvoje, is there anything in the error log? 

Can you try to download a 4.23 from our site and see if this works for you?

https://www.eclipse.org/downloads/
Comment 4 Hrvoje Lončar CLA 2022-03-22 11:09:13 EDT
Hi Wim,
I'll do the research and I'll get back to you.
I'm planning to install clean STS and clean 4.23
Then I'll check is it working.
Afther that I plan to add plugins to both as much as I can to get similar state as I have on my home STS which I use to work.
So far I have clean 4.23 and there is no bug.
I'll be back in some time when I do more testing.
Comment 5 Dirk Steinkamp CLA 2022-03-22 11:11:42 EDT
Do you use Lombok? Then this is probably a duplicate of https://bugs.eclipse.org/bugs/show_bug.cgi?id=579168

Solution for Lombok problem is here: https://github.com/projectlombok/lombok/issues/3134#issuecomment-1069662386
Comment 6 Wim Jongman CLA 2022-03-22 11:12:11 EDT
(In reply to Hrvoje Lončar from comment #4)
> Hi Wim,
> I'll do the research and I'll get back to you.
> I'm planning to install clean STS and clean 4.23
> Then I'll check is it working.
> Afther that I plan to add plugins to both as much as I can to get similar
> state as I have on my home STS which I use to work.
> So far I have clean 4.23 and there is no bug.
> I'll be back in some time when I do more testing.

Wonderful! Let us know if you know more.
Comment 7 Hrvoje Lončar CLA 2022-03-22 11:14:08 EDT
1) @Wim

When STS has clean install with no plugins - rename works as expected.
I'll add one by one plugins and see what happens.

2) @Dirk

Yes, I use Lombok and it seem you found what's goin' on
Comment 8 Hrvoje Lončar CLA 2022-03-22 11:14:14 EDT
1) @Wim

When STS has clean install with no plugins - rename works as expected.
I'll add one by one plugins and see what happens.

2) @Dirk

Yes, I use Lombok and it seem you found what's goin' on
Comment 9 Hrvoje Lončar CLA 2022-03-22 11:16:33 EDT
Ok, now I can confirm after applying latest Lombok 1.18.22 to Eclipse STS, rename is not working anymore.
Comment 10 Hrvoje Lončar CLA 2022-03-22 11:17:57 EDT
And also after applying latest Lombok v1.18.22 to standard Eclipse 4.23, rename is not working anymore.
Comment 11 Hrvoje Lončar CLA 2022-03-22 11:29:52 EDT
And finally I can confirm that if you apply fixed Lombok version that was created today, rename works again:
https://github.com/projectlombok/lombok/files/8274291/lombok.zip

The url to the fixed version is taken from this conversation:
https://github.com/projectlombok/lombok/issues/3134#issuecomment-1069662386
Comment 12 Wim Jongman CLA 2022-03-22 11:32:19 EDT
(In reply to Hrvoje Lončar from comment #10)
> And also after applying latest Lombok v1.18.22 to standard Eclipse 4.23,
> rename is not working anymore.

Correct, the lombok version with the patch has not been released.
Comment 13 Andrey Loskutov CLA 2022-03-22 12:24:19 EDT
dup

*** This bug has been marked as a duplicate of bug 579168 ***