Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 576216 - The z-order of edges changes the drawing of some diagram
Summary: The z-order of edges changes the drawing of some diagram
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 7.0.0   Edit
Assignee: Laurent Redor CLA
QA Contact: Jessy Mallet CLA
URL:
Whiteboard:
Keywords:
Depends on: 576057
Blocks:
  Show dependency tree
 
Reported: 2021-09-23 05:22 EDT by Laurent Redor CLA
Modified: 2022-02-28 04:22 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2021-09-23 05:22:06 EDT
+++ This bug was initially created as a clone of Bug #576057 +++

Since bug 574273, some diagrams are not drawn exactly as before.

This is "normal" because before, the edges are drawn according to the creation order of their sources. Now, they are drawn according to the creation order of edges.
In the file "diffBeforeAfterZOrder.png", you can see 4 cases:
* Case A: The order of creation of source nodes is the same than the order of creation of edges. For information, the numbers suffixing nodes and edges correspond to the creation order.
    * The display result is the same before and after the new feature concerning z-order.
* Case B: The order of creation of source nodes is not the same than the order of creation of edges. For information, the numbers suffixing nodes and edges correspond to the creation order.
    * The display result is not the same before and after the new feature concerning z-order. So the jumplink is not on the same edge.
* Case C: The order of creation of source nodes is the same than the order of creation of edges. For information, the numbers suffixing nodes and edges correspond to the creation order. In this case, both edges have not bendpoints constraint in model. "c4" has only a bendpoint, added graphically, to avoid an overlap between "c3" and "c4".
    * The display result is the same before and after the new feature concerning z-order.
* Case D: The order of creation of source nodes is not the same than the order of creation of edges. For information, the numbers suffixing nodes and edges correspond to the creation order. In this case, both edges have not bendpoints constraint in model. "d3" has only a bendpoint, added graphically, to avoid an overlap between "d3" and "d4".
    * The display result is not the same before and after the new feature concerning z-order. After the z-order feature, "d3" is drawn in first so without bendpoint and "d4" is drawn in second so with a "graphical bendpoint".
	
The project JumpLinksTest-zOrderRegression.zip contains the diagram used for the above screenshot. After the fix of the issue, the diagram should be drawn as before the feature concerning z-order.

A migration participant must be added to "sort" GMF edges list according to the nodes order.
Comment 1 Eclipse Genie CLA 2021-09-27 12:14:35 EDT
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/185861
Comment 3 Jessy Mallet CLA 2022-01-27 04:09:00 EST
Validated with Sirius 7.0.0.202201120736
Comment 4 Pierre-Charles David CLA 2022-02-28 04:22:38 EST
Available in Sirius 7.0.0, see https://projects.eclipse.org/projects/modeling.sirius/releases/7.0.0